-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use_modular_headers! from Swift Podfiles #156259
Comments
Would including a project migrator for apps be a good thing here? And do we need to modify the SPM migration docs to tell developers to remove it there as well? |
@navaronbracke While in theory this change is necessary, in practice we're not aware of any problems caused by this today. However, we are concerned that an automatic migration could break apps if not done well. For now, we'll fix new apps but not existing apps. Long-term, all existing apps will migrate to SwiftPM and won't be affected by this problem (removing Let me know if you have any concerns! |
…#156342) Follow-up to flutter/packages#7796 Part of #156259
We added `use_modular_headers!` to our `Podfile`s as we originally planned to phase out `use_frameworks!` (see #42204). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager. CocoaPods's `use_frameworks!` and `use_modular_headers!` are two different overlapping options that should not be used together. This change removes the `use_modular_headers!` from the macOS `Podfile` and the iOS Swift `Podfile` (the iOS Objective-C template was recently deprecated #155867). This change only affects _new_ Flutter apps. This change does not include an automatic migration as that could break existing apps. Instead, users are encouraged to migrate from CocoaPods to Swift Package Manager. #156259
â� ï¸� _This PR does not update packages' versions as it only affects unpublished parts of example apps and tests._ We added `use_modular_headers!` to our `Podfile`s as we originally planned to phase out `use_frameworks!` (see flutter/flutter#42204). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager. CocoaPods's `use_frameworks!` and `use_modular_headers!` are two different overlapping options that should not be used together. This change removes the `use_modular_headers!` from example apps' `Podfile`s. This change does not affect packages themselves. Part of flutter/flutter#156259
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Background
We added
use_modular_headers!
to ourPodfile
s as we originally planned to phase outuse_frameworks!
(see #42204). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager.CocoaPods's
use_frameworks!
anduse_modular_headers!
are two different overlapping options that should not be used together. This change removes theuse_modular_headers!
from the macOSPodfile
and the iOS SwiftPodfile
(the iOS Objective-C template was recently deprecated #155867).Work
Remove
use_modular_headers!
from all SwiftPodfile
s.The text was updated successfully, but these errors were encountered: