Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use_modular_headers! from Swift Podfiles #156259

Closed
loic-sharma opened this issue Oct 4, 2024 · 3 comments
Closed

Remove use_modular_headers! from Swift Podfiles #156259

loic-sharma opened this issue Oct 4, 2024 · 3 comments
Assignees
Labels
P3 Issues that are less important to the Flutter project platform-ios iOS applications specifically platform-mac Building on or for macOS specifically team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-ios Triaged by iOS platform team

Comments

@loic-sharma
Copy link
Member

Background

We added use_modular_headers! to our Podfiles as we originally planned to phase out use_frameworks! (see #42204). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager.

CocoaPods's use_frameworks! and use_modular_headers! are two different overlapping options that should not be used together. This change removes the use_modular_headers! from the macOS Podfile and the iOS Swift Podfile (the iOS Objective-C template was recently deprecated #155867).

Work

Remove use_modular_headers! from all Swift Podfiles.

@loic-sharma loic-sharma self-assigned this Oct 4, 2024
@loic-sharma loic-sharma added P3 Issues that are less important to the Flutter project team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically labels Oct 4, 2024
@navaronbracke
Copy link
Contributor

Would including a project migrator for apps be a good thing here? And do we need to modify the SPM migration docs to tell developers to remove it there as well?

@loic-sharma
Copy link
Member Author

loic-sharma commented Oct 7, 2024

@navaronbracke While in theory this change is necessary, in practice we're not aware of any problems caused by this today. However, we are concerned that an automatic migration could break apps if not done well.

For now, we'll fix new apps but not existing apps. Long-term, all existing apps will migrate to SwiftPM and won't be affected by this problem (removing use_modular_headers! is not a prerequisite for the SwiftPM migration). We want to put all our resources on getting the SwiftPM migration right :)

Let me know if you have any concerns!

auto-submit bot pushed a commit that referenced this issue Nov 4, 2024
We added `use_modular_headers!` to our `Podfile`s as we originally planned to phase out `use_frameworks!` (see #42204). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager.

CocoaPods's `use_frameworks!` and `use_modular_headers!` are two different overlapping options that should not be used together. This change removes the `use_modular_headers!` from the macOS `Podfile` and the iOS Swift `Podfile` (the iOS Objective-C template was recently deprecated #155867).

This change only affects _new_ Flutter apps. This change does not include an automatic migration as that could break existing apps. Instead, users are encouraged to migrate from CocoaPods to Swift Package Manager.

#156259
auto-submit bot pushed a commit to flutter/packages that referenced this issue Nov 5, 2024
�� _This PR does not update packages' versions as it only affects unpublished parts of example apps and tests._

We added `use_modular_headers!` to our `Podfile`s as we originally planned to phase out `use_frameworks!` (see flutter/flutter#42204). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager.

CocoaPods's `use_frameworks!` and `use_modular_headers!` are two different overlapping options that should not be used together. This change removes the `use_modular_headers!` from example apps' `Podfile`s. This change does not affect packages themselves.

Part of flutter/flutter#156259
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 Issues that are less important to the Flutter project platform-ios iOS applications specifically platform-mac Building on or for macOS specifically team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-ios Triaged by iOS platform team
Projects
None yet
Development

No branches or pull requests

2 participants