Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-stable]Add a precision to the fragment shader #54518

Conversation

flutteractionsbot
Copy link

@flutteractionsbot flutteractionsbot commented Aug 12, 2024

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

flutter/flutter#152297

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

Fix black screen on OpenGL ES, due to lack of precision in fragment shader.

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

On OpenGL ES, a black screen is shown instead of the Flutter output. This is due to the fragment shader failing compilation due to it lacking a precision statement. Note that this is required in the OpenGL ES specification, though some drivers continue to work instead using a default value for precision.

Workaround:

Is there a workaround for this issue?

There is no workaround.

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

  1. Create default flutter app (flutter create hello_world)
  2. Run Flutter app on an OpenGL ES device, e.g. Raspberry Pi (flutter run).

Expected result:
Default app is correctly rendered.

@flutteractionsbot flutteractionsbot added the cp: review add the cp request to the review queue of release engineers label Aug 12, 2024
@flutteractionsbot
Copy link
Author

@robert-ancell please fill out the PR description above, afterwards the release team will review this request.

Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2024
@auto-submit auto-submit bot merged commit f9db4e5 into flutter:flutter-3.24-candidate.0 Aug 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: desktop autosubmit Merge PR when tree becomes green via auto submit App cp: review add the cp request to the review queue of release engineers platform-linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants