[Impeller] delete unused aiks PictureRecorder. #54495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 11, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 12, 2024
…153257) flutter/engine@d409dcd...1a5e2e5 2024-08-11 [email protected] [Impeller] delete unused aiks PictureRecorder. (flutter/engine#54495) 2024-08-11 [email protected] Roll Skia from 9e3c43cb424c to e3e3fd85802b (1 revision) (flutter/engine#54498) 2024-08-11 [email protected] Roll Skia from 8f5705639815 to 9e3c43cb424c (1 revision) (flutter/engine#54497) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…lutter#153257) flutter/engine@d409dcd...1a5e2e5 2024-08-11 [email protected] [Impeller] delete unused aiks PictureRecorder. (flutter/engine#54495) 2024-08-11 [email protected] Roll Skia from 9e3c43cb424c to e3e3fd85802b (1 revision) (flutter/engine#54498) 2024-08-11 [email protected] Roll Skia from 8f5705639815 to 9e3c43cb424c (1 revision) (flutter/engine#54497) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153257) flutter/engine@d409dcd...1a5e2e5 2024-08-11 [email protected] [Impeller] delete unused aiks PictureRecorder. (flutter/engine#54495) 2024-08-11 [email protected] Roll Skia from 9e3c43cb424c to e3e3fd85802b (1 revision) (flutter/engine#54498) 2024-08-11 [email protected] Roll Skia from 8f5705639815 to 9e3c43cb424c (1 revision) (flutter/engine#54497) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot find any references to this class in the code base, and it doesn't seem used anywhere.