Change element to wait for in AppExtensionTests testAppExtensionLaunching #53358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
approved these changes
Jun 12, 2024
vashworth
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 13, 2024
…150208) flutter/engine@4cb3025...8167dff 2024-06-13 [email protected] Roll Skia from ecc64fb82374 to bf5a0e0dbf41 (2 revisions) (flutter/engine#53376) 2024-06-13 [email protected] Change element to wait for in AppExtensionTests testAppExtensionLaunching (flutter/engine#53358) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 tasks
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…lutter#150208) flutter/engine@4cb3025...8167dff 2024-06-13 [email protected] Roll Skia from ecc64fb82374 to bf5a0e0dbf41 (2 revisions) (flutter/engine#53376) 2024-06-13 [email protected] Change element to wait for in AppExtensionTests testAppExtensionLaunching (flutter/engine#53358) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…lutter#150208) flutter/engine@4cb3025...8167dff 2024-06-13 [email protected] Roll Skia from ecc64fb82374 to bf5a0e0dbf41 (2 revisions) (flutter/engine#53376) 2024-06-13 [email protected] Change element to wait for in AppExtensionTests testAppExtensionLaunching (flutter/engine#53358) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of waiting for the first cell in the share sheet to appear, wait for the first cell matching the predicate to appear. It seems that on macOS 14 it occasionally doesn't find any matches, presumably a race condition - so this will wait up to 10 seconds for the desired elements to appear.
Attempting to fix flutter/flutter#150117. I wasn't able to recreate locally and it only happens flakily in CI so hard to guarantee it will fix.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.