[Impeller] fix NPE caused by implicit sk_sp to fml::Status conversion. #53177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
added
the
autosubmit
gaaclarke
reviewed
Jun 3, 2024
| } | ||
|
|
||
| switch (format) { | ||
| case kPNG: { | ||
| auto png_image = SkPngEncoder::Encode(nullptr, raster_image.get(), {}); | ||
|
|
||
| if (png_image == nullptr) { | ||
| FML_LOG(ERROR) << "Could not convert raster image to PNG."; |
There was a problem hiding this comment.
Wait, do we want to maintain these logs somewhere?
There was a problem hiding this comment.
These strings get returned to the dart:ui layer and printed there as an error.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 3, 2024
…149623) flutter/engine@ea72558...60a7bb2 2024-06-03 [email protected] [Impeller] fix NPE caused by implicit sk_sp to fml::Status conversion. (flutter/engine#53177) 2024-06-03 [email protected] Migrate off deprecated GrVkBackendContext fields (flutter/engine#53122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullptr is converted to fml::Status::OK(nullptr), which we don't null check. Change this to consistently use fml::Status
Discovered in flutter/flutter#148851