Remove RBE crud compile_commands.json #53135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parsing a 21MB json string is not performant - RegExp replacing all occurances in said 21MB string is (~61ms) - Fixes #147767
zanderso
reviewed
May 31, 2024
tools/pkg/engine_build_configs/lib/src/build_config_runner.dart
Outdated
Show resolved
Hide resolved
tools/pkg/engine_build_configs/test/build_config_runner_test.dart
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 31, 2024
…149457) flutter/engine@1814031...990f1ce 2024-05-31 [email protected] Roll Skia from 7193eec6a492 to 337c3c4d1f1b (4 revisions) (flutter/engine#53157) 2024-05-31 [email protected] Remove RBE crud compile_commands.json (flutter/engine#53135) 2024-05-31 [email protected] Roll Skia from f1f13534b0c2 to 7193eec6a492 (3 revisions) (flutter/engine#53153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes reported errors in VSCode when using
clangd