Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix et run #52477

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix et run #52477

merged 1 commit into from
May 1, 2024

Conversation

johnmccutchan
Copy link
Contributor

et run was broken in #51803

this PR adds the missing calls to mangledConfigName before invoking flutter run

et run was broken in flutter#51803

this PR adds the missing calls to mangledConfigName before invoking flutter run
@johnmccutchan johnmccutchan added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2024
@johnmccutchan johnmccutchan requested a review from cbracken May 1, 2024 03:34
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@auto-submit auto-submit bot merged commit 0014e03 into flutter:main May 1, 2024
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 1, 2024
…147649)

flutter/engine@0ce6771...0014e03

2024-05-01 [email protected] Fix et run (flutter/engine#52477)
2024-05-01 [email protected] Roll Skia from 5f4ebd628994 to bfbd738fb97b (2 revisions) (flutter/engine#52479)
2024-05-01 [email protected] Roll Fuchsia Linux SDK from HP2saK9sVOtKvpquC... to PIHl-e41i3mzbriG1... (flutter/engine#52480)
2024-05-01 [email protected] Roll Skia from a6bc04f984d2 to 5f4ebd628994 (1 revision) (flutter/engine#52478)
2024-05-01 [email protected] Roll Dart SDK from c88854d4282c to d946408c559a (1 revision) (flutter/engine#52476)
2024-05-01 [email protected] [Impeller] Document the EGL toolkit. (flutter/engine#52469)
2024-05-01 [email protected] [skwasm] Change default `FilterQuality` to `None` for image shaders. (flutter/engine#52468)
2024-05-01 [email protected] Roll Dart SDK from 3f649c97a08c to c88854d4282c (1 revision) (flutter/engine#52475)
2024-04-30 [email protected] Roll Skia from 30aaaef0390d to a6bc04f984d2 (1 revision) (flutter/engine#52471)
2024-04-30 [email protected] Roll Skia from 85ec65ecd5ec to 30aaaef0390d (4 revisions) (flutter/engine#52466)
2024-04-30 [email protected] Roll Dart SDK from 7a517de88964 to 3f649c97a08c (1 revision) (flutter/engine#52465)
2024-04-30 [email protected] Roll Skia from 77350e051f71 to 85ec65ecd5ec (2 revisions) (flutter/engine#52464)
2024-04-30 [email protected] Roll Skia from 8f2d039e1190 to 77350e051f71 (1 revision) (flutter/engine#52460)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from HP2saK9sVOtK to PIHl-e41i3mz

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants