[Impeller] remove incremental allocation during filled path tessellation. #52401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the goldens run till the sub-builds are done. |
|
It turns out they actually do, you can click into the flutter gold pending task and get a link: https://flutter-engine-gold.skia.org/search?issue=52401&crs=github&patchsets=2&corpus=flutter-engine This still has some bugs :) |
|
🤯 |
…sellation_allocation
…hwilliams/engine into remove_fill_tessellation_allocation
|
Working now! modulo CI issues |
chinmaygarde
approved these changes
May 1, 2024
| point_count += single_point_count; | ||
| } | ||
| auto polyline = path.CreatePolyline( | ||
| // Clang-tidy doesn't know that the points get moved back before |
There was a problem hiding this comment.
Oof, this is hard for me to follow lol. Thanks for the comment.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 2, 2024
…147693) flutter/engine@3087ec1...78dced5 2024-05-02 [email protected] et phone home (flutter/engine#52506) 2024-05-02 [email protected] [web] Expose browser_detection through ui_web. (flutter/engine#52380) 2024-05-02 [email protected] [Impeller] remove incremental allocation during filled path tessellation. (flutter/engine#52401) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
This was about a 10% reduction in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't allocate a polyline (and resulting std::vectors) when performing convex tessellation. Instead use a listener pattern and iterate through path verbs.