Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "gclient sync" warning call during pre-rebase #52342

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 23, 2024

Remove pre-rebase check from gclient sync warning, and instead remove the warning call from pre_rebase_command

Follow-up to #52133 (comment)

@jmagman jmagman requested a review from zanderso April 23, 2024 22:35
@jmagman jmagman self-assigned this Apr 23, 2024
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 25, 2024
@auto-submit auto-submit bot merged commit 96898c4 into flutter:main Apr 25, 2024
29 checks passed
@jmagman jmagman deleted the rebase branch April 25, 2024 23:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 26, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 26, 2024
…147399)

flutter/engine@e99fc6e...11a857e

2024-04-26 [email protected] Roll Dart SDK from 29afb0500d51 to e1bc6a6bca79 (1 revision) (flutter/engine#52405)
2024-04-26 [email protected] Roll Fuchsia Linux SDK from PJBX8xxRnd5vCFnQM... to Rc4K-_-ym7vwUzXyo... (flutter/engine#52404)
2024-04-25 [email protected] Remove "gclient sync" warning call during pre-rebase (flutter/engine#52342)
2024-04-25 [email protected] Roll Dart SDK from f9c9894a2500 to 29afb0500d51 (1 revision) (flutter/engine#52399)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from PJBX8xxRnd5v to Rc4K-_-ym7vw

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants