[Windows] Prepare to add/remove views #51908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
Apr 4, 2024
| EXPECT_TRUE(compositor.Present(view()->view_id(), nullptr, 0)); | ||
| } | ||
|
|
||
| TEST_F(CompositorOpenGLTest, HeadlessPresentIgnored) { |
There was a problem hiding this comment.
The following tests were all replaced by WindowsTest.PresentHeadless:
CompositorOpenGLTest.HeadlessPresentIgnoredCompositorOpenGLTest.UnknownViewIgnoredCompositorSoftwareTest.HeadlessPresentIgnoredCompositorSoftwareTest.UnknownViewIgnored
(Presenting to the implicit view while in headless mode is effectively the same thing as presenting to an unknown view)
loic-sharma
commented
Apr 4, 2024
| @@ -315,9 +315,49 @@ void drawHelloWorld() { | |||
| ..addPicture(ui.Offset.zero, picture) | |||
| ..pop(); | |||
|
|
|||
| ui.window.render(sceneBuilder.build()); | |||
| ui.PlatformDispatcher.instance.implicitView?.render(sceneBuilder.build()); | |||
There was a problem hiding this comment.
The window global is deprecated and replaced by PlatformDispatcher.instance.implicitView. This isn't necessary for this PR, but removes a usage of a deprecated member :)
loic-sharma
commented
Apr 4, 2024
|
|
||
| ViewControllerPtr controller{builder.Run()}; | ||
| ASSERT_NE(controller, nullptr); | ||
| auto& context = GetContext(); |
There was a problem hiding this comment.
The extra thread was unnecessary for this test. Consider reviewing this with whitespace changes disabled: https://github.com/flutter/engine/pull/51908/files?w=1#diff-f0b8369989e179cde8da71010c79f2c542f16c55f91e9d9aeae1a3fe769cf83dR548
cbracken
reviewed
Apr 4, 2024
yaakovschectman
approved these changes
Apr 4, 2024
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 4, 2024
…146311) flutter/engine@dcc99d6...d44462a 2024-04-04 [email protected] [Windows] Prepare to add/remove views (flutter/engine#51908) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146311) flutter/engine@dcc99d6...d44462a 2024-04-04 [email protected] [Windows] Prepare to add/remove views (flutter/engine#51908) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring with no semantic changes.
Prepare the Windows embedder to add/remove views. In a multi-view world, the platform thread can remove a view while the raster thread presenting to the same view. A lock will be introduced to ensure this does not happen. This shuffles the code around so that the engine can acquire the lock before the compositor presents to the view.
Prepares for flutter/flutter#138179
Part of flutter/flutter#142845
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.