[CP] Revert "[Impeller] stencil buffer record/replay instead of MSAA storage. #51416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge. (flutter#47397)" This reverts commit 04329c5.
zanderso
approved these changes
Mar 14, 2024
|
There is no cherry pick request for this one. @dnfield is working on a test for this one. So we should probably wait for that too. |
|
Checked this against the 3.19 branch. Before: After: |
|
I've added a pixel test that I'll also add to the main branch. It fails without this revert, and passes with it. |
This was referenced Mar 14, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
Same test as in #51416. This test should pass without the revert here because the StC related changes make the optimized path work again.
XilaiZhang
added
the
autosubmit
auto-submit
bot
merged commit ba0444a
into
flutter:flutter-3.19-candidate.1
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #47397 to fix flutter/flutter#144211 in 3.19.
This reverts commit 04329c5.