Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view focus direction detection to flutter web. #50843

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Add view focus direction detection to flutter web. #50843

merged 1 commit into from
Feb 22, 2024

Conversation

tugorez
Copy link
Contributor

@tugorez tugorez commented Feb 21, 2024

Add view focus direction detection to flutter web.

Relevant Issues are:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Feb 21, 2024
@tugorez tugorez marked this pull request as ready for review February 22, 2024 00:32
@tugorez tugorez requested a review from ditman February 22, 2024 00:32
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I wonder if the source of keyboard events could be the Keyboard/RawKeyboard bindings :/

@tugorez tugorez added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2024
@tugorez
Copy link
Contributor Author

tugorez commented Feb 22, 2024

This LGTM, I wonder if the source of keyboard events could be the Keyboard/RawKeyboard bindings :/

Great call. Left a comment in flutter/flutter#137443 to not forget about this.

@auto-submit auto-submit bot merged commit 7eeb697 into flutter:main Feb 22, 2024
26 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 22, 2024
…143911)

flutter/engine@bf5c003...7eeb697

2024-02-22 [email protected] Add view focus direction detection to flutter web. (flutter/engine#50843)
2024-02-22 [email protected] Add a similar `runIf` guard to `web_engine` as web framework. (flutter/engine#50846)
2024-02-22 [email protected] Add scheduleWarmUpFrame (flutter/engine#50570)
2024-02-22 [email protected] Remove/reduce unused or private methods and add tests to `SkiaGoldClient` (flutter/engine#50844)
2024-02-22 [email protected] Clean up contributing formatting, add a Skia gold callout (flutter/engine#50828)
2024-02-21 [email protected] Make Android Studio be able to run android embedding unit tests out of the box (flutter/engine#50840)
2024-02-21 [email protected] Shift some deps to //flutter/third_party (flutter/engine#50830)
2024-02-21 [email protected] Make the view focus binding report focus transitions across elements. (flutter/engine#50610)
2024-02-21 [email protected] [macOS] Wrap FlutterEngineTest in autoreleasepool (flutter/engine#50832)
2024-02-21 [email protected] Update the vulkan_glfw sample for the latest roll of vulkan-deps (flutter/engine#50839)
2024-02-21 [email protected] Roll Skia from 8fa858855820 to 57490c8d257e (6 revisions) (flutter/engine#50833)
2024-02-21 [email protected] Starts a .ci.yaml parser (flutter/engine#50783)
2024-02-21 [email protected] Roll Dart SDK from f344e2266468 to 0f0f7400c38a (6 revisions) (flutter/engine#50837)
2024-02-21 [email protected] [Windows] Fix top-level message procedure order (flutter/engine#50797)
2024-02-21 [email protected] Tweak verbose log messages in ImageReaderSurfaceProducer (flutter/engine#50831)
2024-02-21 [email protected] Add a throw statement for imgtestAdd non 0 exit codes. (flutter/engine#50829)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants