-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Impeller] cache onscreen render targets. #50751
[Impeller] cache onscreen render targets. #50751
Conversation
@dnfield Test added |
…143875) flutter/engine@52ffcaa...bf5c003 2024-02-21 [email protected] Roll Skia from 9d86359b5fe8 to 8fa858855820 (15 revisions) (flutter/engine#50827) 2024-02-21 [email protected] Add the `scenario_app` `'solid_blue'` golden to the Android test suite (flutter/engine#50801) 2024-02-21 [email protected] Ignore EOF newline characters and added tests to `dir_contents_diff` tool (flutter/engine#50805) 2024-02-21 [email protected] Make the GL context current in EmbedderSurfaceGLImpeller before creating the GPU surface (flutter/engine#50807) 2024-02-21 [email protected] Fail engine post-submit on skia-gold comparions. (flutter/engine#50826) 2024-02-21 [email protected] Remove WindowManager reflection in SingleViewPresentation.java (flutter/engine#49996) 2024-02-21 [email protected] [Impeller] applied the lerp hack to blur (roughly 2x speedup?) (flutter/engine#50790) 2024-02-21 [email protected] Migrate the Fuchsia embedder to the Dart_RecordTimelineEvent API (flutter/engine#50823) 2024-02-21 [email protected] Hook ImageReaderSurfaceProducer to the onTrimMemory listener interface (flutter/engine#50792) 2024-02-21 [email protected] Fix the local-only lint errors due to an unexpected `GeneratedPluginRegistrant.java` (flutter/engine#50795) 2024-02-21 [email protected] [Impeller] cache onscreen render targets. (flutter/engine#50751) 2024-02-21 [email protected] Use 'et format' in CI. Check formatting of all files in CI (flutter/engine#50810) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
revert: breaking flutter tester --enable-impeller workflow. |
A reason for requesting a revert of flutter/engine/50751 could |
Reason for revert: breaking flutter tester --enable-impeller workflow |
This reverts commit db49661.
Reverts #50751 Initiated by: jonahwilliams Reason for reverting: breaking flutter tester --enable-impeller workflow Original PR Author: jonahwilliams Reviewed By: {matanlurey} This change reverts the following previous change: Original Description: Currently we cache render pass objects to offscreen render targets only. Caching onscreen doesn't work as 1) the render targets are stored on the texture_vk object and 2) the texture_vk object is recreated for each frame (see https://github.com/flutter/engine/blob/main/impeller/renderer/backend/vulkan/surface_vk.cc#L14 ). To make sure the render pass is cached, move the storage to the texture source. part of flutter/flutter#141750
|
This particular test is using the "live" binding. Something's not keeping the vk objects alive long enough I think. |
Currently we cache render pass objects to offscreen render targets only. Caching onscreen doesn't work as 1) the render targets are stored on the texture_vk object and 2) the texture_vk object is recreated for each frame (see https://github.com/flutter/engine/blob/main/impeller/renderer/backend/vulkan/surface_vk.cc#L14 ).
To make sure the render pass is cached, move the storage to the texture source.
part of flutter/flutter#141750