Fix header-guard naming convention in shell/.
#49006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
requested review from
cbracken,
chinmaygarde and
loic-sharma
as code owners
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/49006, due to - The status or check suite Linux linux_android_debug_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
dnfield
approved these changes
Dec 14, 2023
loic-sharma
approved these changes
Dec 14, 2023
cbracken
approved these changes
Dec 14, 2023
cbracken
reviewed
Dec 14, 2023
| #ifndef FLUTTER_FLUTTERBINARYMESSENGER_H_ | ||
| #define FLUTTER_FLUTTERBINARYMESSENGER_H_ | ||
| #ifndef FLUTTER_SHELL_PLATFORM_DARWIN_COMMON_FRAMEWORK_HEADERS_FLUTTERBINARYMESSENGER_H_ | ||
| #define FLUTTER_SHELL_PLATFORM_DARWIN_COMMON_FRAMEWORK_HEADERS_FLUTTERBINARYMESSENGER_H_ |
There was a problem hiding this comment.
The public headers were intentional since users import them as Flutter/FlutterBinaryMessenger.h but in the end the symbol itself doesn't matter so long as it's unique (and ideally consistent), which this is, so lgtm.
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/49006, due to - The status or check suite Linux linux_fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2023
…140195) flutter/engine@0e7248d...4cb3ba7 2023-12-15 [email protected] Roll Skia from 79f23e8d8b5d to cd2f06086c96 (1 revision) (flutter/engine#49069) 2023-12-15 [email protected] Roll Dart SDK from 0471164827b9 to f1e37ed8917e (1 revision) (flutter/engine#49065) 2023-12-15 [email protected] [Impeller] impellerc: delete unused code (flutter/engine#49061) 2023-12-15 [email protected] [Impeller] split out gradient tests from aiks_unittests (flutter/engine#49050) 2023-12-15 [email protected] Revert "[Impeller] Turned on new blur." (flutter/engine#49062) 2023-12-14 [email protected] Fix header-guard naming convention in `shell/`. (flutter/engine#49006) 2023-12-14 [email protected] Manual roll of Dart SDK from a677378ae254 to 0471164827b9 (flutter/engine#49054) 2023-12-14 [email protected] Rename `font-subset` to `font_subset`. (flutter/engine#49051) 2023-12-14 [email protected] Roll Skia from 92935b91193a to 79f23e8d8b5d (1 revision) (flutter/engine#49056) 2023-12-14 [email protected] Suppress warning for the new Activity library. (flutter/engine#49046) 2023-12-14 [email protected] [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038) 2023-12-14 [email protected] Unpin mac_toolchain version (flutter/engine#48994) 2023-12-14 [email protected] [Impeller] Turned on new blur. (flutter/engine#48472) 2023-12-14 [email protected] Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 12, 2024
1. Change chromium default branch from master (404) to main. 2. When I migrated the template to ARC is triggered a `-Wobjc-redundant-literal-use` error, so fix that. Engine PR is flutter/engine#51981 3. Update to `FLUTTER_SHELL_PLATFORM_EMBEDDER_TEST_UTILS_KEY_CODES_G_H_` to match flutter/engine#49006 This only updates the template and the script--I ran the script to validate it worked and built in the engine, but did not check in the actual generated key code changes (filed #146480 for that).
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
1. Change chromium default branch from master (404) to main. 2. When I migrated the template to ARC is triggered a `-Wobjc-redundant-literal-use` error, so fix that. Engine PR is flutter/engine#51981 3. Update to `FLUTTER_SHELL_PLATFORM_EMBEDDER_TEST_UTILS_KEY_CODES_G_H_` to match flutter/engine#49006 This only updates the template and the script--I ran the script to validate it worked and built in the engine, but did not check in the actual generated key code changes (filed flutter#146480 for that).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of landing #48903.
Some of these actually seem like potential owchy spots, i.e.
#ifndef FLUTTER_FLUTTER_H_.