Fix autofill for android #40771
Fix autofill for android #40771
Conversation
bparrishMines
requested review from
LongCatIsLooong,
stuartmorgan and
reidbaker
| @@ -92,6 +92,15 @@ public void attachToFlutterEngine_alertsPlatformViews() { | |||
| verify(platformViewsController, times(1)).attachToView(flutterView); | |||
| } | |||
|
|
|||
| @Test | |||
| public void flutterView_importantForAutofillDoesNotExcludeDescendants() { | |||
There was a problem hiding this comment.
Is it possible to test not that the value is set but instead that a child view can have autofill?
This feels a bit like a change detector test.
There was a problem hiding this comment.
Does this test need to indicate that it should only run for android o and above?
There was a problem hiding this comment.
Is it possible to test not that the value is set but instead that a child view can have autofill?
This feels a bit like a change detector test.
I wasn't able to find a way to test if child views receive autofills automatically. I tried to manually call autofill with no luck. And the documentation only provides an example to test it manually: https://developer.android.com/guide/topics/text/autofill-optimize.
Does this test need to indicate that it should only run for android o and above?
I believe the method is only callable on versions O and above. Without the version check, we would get lint warnings that the method would cause crashes on lower versions.
There was a problem hiding this comment.
@bparrishMines approved independent of a different method of testing.
bparrishMines
added
the
autosubmit
Fix autofill for android
Fixes flutter/flutter#92165.
Temporary fix for plugin: flutter/packages#3588
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.