Adding sdk_version to mac builds for dart-internal. #37651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
reviewed
Nov 15, 2022
The osx_sdk version isn't getting propagated to the sub-builds, so adding a property to pass it in. Bug:b/232552448
godofredoc
approved these changes
Nov 16, 2022
yusuf-goog
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 37651, due to - The status or check suite Mac Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 16, 2022
…115410) * fa0f252a2 Roll Dart SDK from 8132f04a0b86 to 7163c9627d98 (1 revision) (flutter/engine#37657) * c22520758 Mark Linux Web Engine Bringup. (flutter/engine#37658) * 03e9a97f8 Adding sdk_version to mac builds for dart-internal. (flutter/engine#37651)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
The osx_sdk version isn't getting propagated to the sub-builds, so adding a property to pass it in. Bug:b/232552448
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115410) * fa0f252a2 Roll Dart SDK from 8132f04a0b86 to 7163c9627d98 (1 revision) (flutter/engine#37657) * c22520758 Mark Linux Web Engine Bringup. (flutter/engine#37658) * 03e9a97f8 Adding sdk_version to mac builds for dart-internal. (flutter/engine#37651)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115410) * fa0f252a2 Roll Dart SDK from 8132f04a0b86 to 7163c9627d98 (1 revision) (flutter/engine#37657) * c22520758 Mark Linux Web Engine Bringup. (flutter/engine#37658) * 03e9a97f8 Adding sdk_version to mac builds for dart-internal. (flutter/engine#37651)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The osx_sdk version isn't getting propagated to the sub-builds, so adding a property to pass it in.
Bug:b/232552448
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.