-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP] [Impeller] Fixes for rendering issues in flutter-3.6-candidate.0 #37558
[CP] [Impeller] Fixes for rendering issues in flutter-3.6-candidate.0 #37558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We might want to also throw #37561 into the mix. I think the reason we haven't noticed it yet is that the default CTM is nearly always scaled up a bit on high DPI devices. For example, on my iPhone 12 Mini, the CTM gets scaled up by 3x on all of the DisplayLists that Impeller receives -- that leaves a buffer on the bottom and right sides of the layer and masks the problem for some appended scales and translations in the -x/-y direction. |
@godofredoc there seems to be an error in .ci.yaml from a change in 0075e10. Do you know how to resolve this so we can get this cherry pick in for the next beta? |
b216a62
to
cbb46c3
Compare
The recipes branch was not created. |
cbb46c3
to
ac71e0f
Compare
@jonahwilliams would you mind rebasing the PR? |
…er#37546) * Include the new primitive type in the pipeline hash * Add test
Sorry I meant to ask @zanderso |
ac71e0f
to
3b46598
Compare
Done. |
This is a CP PR for
Which fix flaky rendering issues in Impeller.