Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] [Impeller] Fixes for rendering issues in flutter-3.6-candidate.0 #37558

Merged
merged 2 commits into from
Nov 16, 2022
Merged

[CP] [Impeller] Fixes for rendering issues in flutter-3.6-candidate.0 #37558

merged 2 commits into from
Nov 16, 2022

Conversation

zanderso
Copy link
Member

@zanderso zanderso mentioned this pull request Nov 12, 2022
Closed
jonahwilliams
jonahwilliams approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero
Copy link
Member

bdero commented Nov 12, 2022 •
edited
Loading

We might want to also throw #37561 into the mix. I think the reason we haven't noticed it yet is that the default CTM is nearly always scaled up a bit on high DPI devices. For example, on my iPhone 12 Mini, the CTM gets scaled up by 3x on all of the DisplayLists that Impeller receives -- that leaves a buffer on the bottom and right sides of the layer and masks the problem for some appended scales and translations in the -x/-y direction.

@itsjustkevin
Copy link
Contributor

@zanderso did we want to add #37561 as referenced by @bdero?

@zanderso
Copy link
Member Author

@zanderso did we want to add #37561 as referenced by @bdero?

If that one is needed, I'll file a separate issue and PR for it. So it doesn't need to be included in this one.

@itsjustkevin
Copy link
Contributor

@godofredoc there seems to be an error in .ci.yaml from a change in 0075e10. Do you know how to resolve this so we can get this cherry pick in for the next beta?

@godofredoc
Copy link
Contributor

@godofredoc there seems to be an error in .ci.yaml from a change in 0075e10. Do you know how to resolve this so we can get this cherry pick in for the next beta?

The recipes branch was not created.

@godofredoc
Copy link
Contributor

@jonahwilliams would you mind rebasing the PR?

@godofredoc
Copy link
Contributor

@jonahwilliams would you mind rebasing the PR?

Sorry I meant to ask @zanderso

@zanderso
Copy link
Member Author

@jonahwilliams would you mind rebasing the PR?

Sorry I meant to ask @zanderso

Done.

@zanderso zanderso merged commit 521692a into flutter:flutter-3.6-candidate.0 Nov 16, 2022
@zanderso zanderso deleted the impeller-fixes branch November 16, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zanderso @bdero @itsjustkevin @godofredoc @jonahwilliams @chinmaygarde @iskakaushik