Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Eliminate macOS 10.14 availability check #37490

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Nov 10, 2022

Now that the macOS embedders have all been updated to use a minimum macOS SDK of 10.14, eliminate the remaining @available checks dependent on that version.

This is one in a series of post-10.14 cleanup patches.

No tests are added since the code removed was a workaround for macOS 10.13. We now build with both a minimum SDK and deployment target of 10.14, and as such the workaround was already disabled at compile-time, making this change effectively a no-op.

Issue: flutter/flutter#114445

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Nov 10, 2022

test-exempt: removing code

Now that the macOS embedders have all been updated to use a minimum
macOS SDK of 10.14, eliminate the remaining @available checks dependent
on that version.

Issue: flutter/flutter#114445
@dnfield
Copy link
Contributor

dnfield commented Nov 10, 2022

Nice. I think this means we can remove an ANGLE/Vulkan work around as well...

@dnfield
Copy link
Contributor

dnfield commented Nov 10, 2022

In //flutter/vulkan/procs/vulkan_interface.h we can remove lines 27-33

@dnfield
Copy link
Contributor

dnfield commented Nov 10, 2022

And there's another macOS 10.14 check in FlutterRenderingBackend.mm

@cbracken
Copy link
Member Author

cbracken commented Nov 10, 2022

Thanks! The first pass at this did a removal of the Vulcan undef but looked like it may have triggered a segfault in the impeller mac tests, so reverted that file. Will take another look shortly.

FlutterRenderingBackend.{h,mm} were removed in #37448.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2022
@auto-submit auto-submit bot merged commit ad89f6a into flutter:main Nov 10, 2022
@cbracken cbracken deleted the available branch November 10, 2022 21:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 10, 2022
…115122)

* ad89f6ab2 [macOS] Eliminate macOS 10.14 availability check (flutter/engine#37490)

* 30e2cedfa chore: fix Dart SDK DEPS file link in DEPS (flutter/engine#37496)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
Now that the macOS embedders have all been updated to use a minimum
macOS SDK of 10.14, eliminate the remaining @available checks dependent
on that version.

Issue: flutter/flutter#114445
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115122)

* ad89f6ab2 [macOS] Eliminate macOS 10.14 availability check (flutter/engine#37490)

* 30e2cedfa chore: fix Dart SDK DEPS file link in DEPS (flutter/engine#37496)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115122)

* ad89f6ab2 [macOS] Eliminate macOS 10.14 availability check (flutter/engine#37490)

* 30e2cedfa chore: fix Dart SDK DEPS file link in DEPS (flutter/engine#37496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants