Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiwindow, macOS] FlutterCompositor::Present receives view_id #37391

Merged
merged 5 commits into from
Nov 15, 2022

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Nov 7, 2022

This PR propagates the multiview design from macos/FlutterCompositor::Present to macos/FlutterEngine, stopping before embedder/FlutterCompositor::present_layers_callback.

This is as far as we can get from this side without changing the embedder API.

Part of the multiwindow project (design doc).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dkwingsmt dkwingsmt self-assigned this Nov 9, 2022
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2022
@cbracken
Copy link
Member

Hmmm - this failure looks unrelated to your patch:

[5297/5413] ACTION //flutter/lib/snapshot:generate_snapshot_bin(//build/toolchain/mac:ios_clang_x64_sim)
FAILED: gen/flutter/lib/snapshot/vm_isolate_snapshot.bin gen/flutter/lib/snapshot/vm_snapshot_instructions.bin gen/flutter/lib/snapshot/isolate_snapshot.bin gen/flutter/lib/snapshot/isolate_snapshot_instructions.bin 
vpython3 ../../build/gn_run_binary.py clang_x64/gen_snapshot --snapshot_kind=core --enable_mirrors=false --vm_snapshot_data=/Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim/gen/flutter/lib/snapshot/vm_isolate_snapshot.bin --vm_snapshot_instructions=/Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim/gen/flutter/lib/snapshot/vm_snapshot_instructions.bin --isolate_snapshot_data=/Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim/gen/flutter/lib/snapshot/isolate_snapshot.bin --isolate_snapshot_instructions=/Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim/gen/flutter/lib/snapshot/isolate_snapshot_instructions.bin /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim/flutter_patched_sdk/platform_strong.dill
Can't load Kernel binary: Invalid SDK hash.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 14, 2022

auto label is removed for flutter/engine, pr: 37391, due to - The status or check suite Mac iOS clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

@cbracken
Copy link
Member

I wonder if there's some CI bug where the framework version used is tied to roughly what framework hash was current at the time your patch's parent engine SHA was current? Maybe rebasing to tip-of-tree engine would help?

@dkwingsmt dkwingsmt merged commit 28eeba5 into flutter:main Nov 15, 2022
@dkwingsmt dkwingsmt deleted the propagate-compositor-to-engine branch November 15, 2022 00:03
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 15, 2022
…115335)

* 6976132e5 [web] Switch to doubles (flutter/engine#37336)

* c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598)

* 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596)

* 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414)

* 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594)

* d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597)

* 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603)

* 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391)

* 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606)

* 78ae24140 Revert "[web] Switch to doubles (#37336)" (flutter/engine#37609)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115335)

* 6976132e5 [web] Switch to doubles (flutter/engine#37336)

* c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598)

* 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596)

* 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414)

* 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594)

* d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597)

* 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603)

* 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391)

* 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606)

* 78ae24140 Revert "[web] Switch to doubles (flutter#37336)" (flutter/engine#37609)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115335)

* 6976132e5 [web] Switch to doubles (flutter/engine#37336)

* c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598)

* 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596)

* 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414)

* 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594)

* d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597)

* 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603)

* 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391)

* 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606)

* 78ae24140 Revert "[web] Switch to doubles (flutter#37336)" (flutter/engine#37609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants