-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multiwindow, macOS] FlutterCompositor::Present receives view_id #37391
[Multiwindow, macOS] FlutterCompositor::Present receives view_id #37391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm - this failure looks unrelated to your patch:
|
auto label is removed for flutter/engine, pr: 37391, due to - The status or check suite Mac iOS clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
I wonder if there's some CI bug where the framework version used is tied to roughly what framework hash was current at the time your patch's parent engine SHA was current? Maybe rebasing to tip-of-tree engine would help? |
…115335) * 6976132e5 [web] Switch to doubles (flutter/engine#37336) * c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598) * 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596) * 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414) * 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594) * d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597) * 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603) * 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391) * 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606) * 78ae24140 Revert "[web] Switch to doubles (#37336)" (flutter/engine#37609)
…tter#37391) * Impl and test * Change to default view
…lutter#115335) * 6976132e5 [web] Switch to doubles (flutter/engine#37336) * c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598) * 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596) * 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414) * 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594) * d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597) * 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603) * 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391) * 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606) * 78ae24140 Revert "[web] Switch to doubles (flutter#37336)" (flutter/engine#37609)
…lutter#115335) * 6976132e5 [web] Switch to doubles (flutter/engine#37336) * c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598) * 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596) * 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414) * 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594) * d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597) * 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603) * 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391) * 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606) * 78ae24140 Revert "[web] Switch to doubles (flutter#37336)" (flutter/engine#37609)
This PR propagates the multiview design from
macos/FlutterCompositor::Present
tomacos/FlutterEngine
, stopping beforeembedder/FlutterCompositor::present_layers_callback
.This is as far as we can get from this side without changing the embedder API.
Part of the multiwindow project (design doc).
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.