Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland "ChromeOS/Android trackpad gestures" #34060

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Reland "ChromeOS/Android trackpad gestures" #34060

merged 2 commits into from
Jun 16, 2022

Conversation

moffatman
Copy link
Contributor

Original PR was #31595
Reverted in #34046

Start sending PointerPanZoom events from ChromeOS/Android when trackpad is used

Fixes flutter/flutter#23604

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@moffatman
Copy link
Contributor Author

cc @dkwingsmt

dkwingsmt
dkwingsmt reviewed Jun 15, 2022
View reviewed changes
shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java
} else if (pointerChange == PointerChange.UP || pointerChange == PointerChange.CANCEL) {
return PointerChange.PAN_ZOOM_END;
}
throw new AssertionError("Unexpected pointer change");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the errors be caught anywhere, or they will never occur given how Flutter's code is written?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error should never be thrown. I saw some other uses of uncaught AssertionError for similar cases.

@dkwingsmt dkwingsmt merged commit 27006fe into flutter:main Jun 16, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
01ced22 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
3f631f9 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
ee0f233 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
6706008 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
4a068a3 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
5066b63 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
ee563f8 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
a1e09a8 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
fdafbb9 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
1913c0a 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
13d8fcc 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
7c389a0 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
3ea3abc 
…4060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
27006fe Reland "ChromeOS/Android trackpad gestures" (flutter/engine#3…
3f8e568 
…4060)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@moffatman @houhuayong
Reland "ChromeOS/Android trackpad gestures" (flutter#34060)
21c714c 
* Android trackpad gestures

* Try to fix lint problem
@bleroux bleroux mentioned this pull request Oct 27, 2022
Closed
@moffatman moffatman mentioned this pull request Nov 14, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees
No one assigned
Labels
platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should support trackpad gestures from host
2 participants
@moffatman @dkwingsmt