Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo "SetTestFluttterStub", "FluttterActivity" and "implementantions" #33551

Merged
merged 7 commits into from
May 23, 2022

Conversation

nilsreichardt
Copy link
Contributor

As recommended in #33547 (comment), I fixed all typos in one PR.

Fixes flutter/flutter#104366
Fixes flutter/flutter#104367
Fixes flutter/flutter#104368
Fixes flutter/flutter#104369
Fixes flutter/flutter#104370

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the typo fixes.

In a separate patch, we should figure out how to dry up the stubs. cc @cbracken

@nilsreichardt
Copy link
Contributor Author

Do I need to request a test exempt?

@cbracken
Copy link
Member

Do I need to request a test exempt?

@nilsreichardt yep. I've just pinged @Hixie on Discord for a test exemption.

@nilsreichardt
Copy link
Contributor Author

@cbracken Great, thanks!

@Hixie
Copy link
Contributor

Hixie commented May 23, 2022

test-exempt: only affects comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment