-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo "SetTestFluttterStub", "FluttterActivity" and "implementantions" #33551
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the typo fixes.
In a separate patch, we should figure out how to dry up the stubs. cc @cbracken
Do I need to request a test exempt? |
@nilsreichardt yep. I've just pinged @Hixie on Discord for a test exemption. |
@cbracken Great, thanks! |
test-exempt: only affects comments |
…ons" (flutter#33551) As recommended in flutter#33547 (comment), I fixed all typos in one PR. Fixes flutter/flutter#104366 Fixes flutter/flutter#104367 Fixes flutter/flutter#104368 Fixes flutter/flutter#104369 Fixes flutter/flutter#104370
As recommended in #33547 (comment), I fixed all typos in one PR.
Fixes flutter/flutter#104366
Fixes flutter/flutter#104367
Fixes flutter/flutter#104368
Fixes flutter/flutter#104369
Fixes flutter/flutter#104370
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.