Vulkan support in the Embedder API #29391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
bdero
force-pushed
the
bdero/vulkan-embedder
branch
from
351508c
to
668cd92
Compare
arbreng
reviewed
Oct 28, 2021
shell/platform/embedder/embedder.h
Outdated
| const FlutterVulkanImage* /* image */); | ||
| typedef uint64_t* (*Uint64Callback)(void* /* user data */); | ||
|
|
||
| typedef uint64_t* (*FlutterVulkanPresentImageCallback)(void* /* user data */, |
shell/platform/embedder/embedder.h
Outdated
| FlutterVulkanPhysicalDeviceHandle physical_device; | ||
| // VkDevice handle. | ||
| FlutterVulkanDeviceHandle device; | ||
| ProcResolver get_proc_address_callback; |
There was a problem hiding this comment.
Where is "ProcResolver" defined? How is this one different from "get_instance_proc_address_callback"?
There was a problem hiding this comment.
Ah, this signature is used in the GL renderer. I think this was supposed to be instance-less vkGetInstanceProcAddr in the doc, but on second thought I don't see a reason why this would be useful as a separate callback. Removed.
bdero
force-pushed
the
bdero/vulkan-embedder
branch
3 times, most recently
from
62671fa
to
f3ecb6e
Compare
fluttergithubbot
force-pushed
the
master
branch
from
b1a8771
to
2962099
Compare
|
Is this in a state where I could try testing it w/ Fuchsia code -- IE try to get Fuchsia to use EmbedderSurfaceVulkan? |
bdero
force-pushed
the
bdero/vulkan-embedder
branch
from
249e0fa
to
5ae6eeb
Compare
|
I think this is about ready for trying out through the Embedder API surface itself (compositor and all), but the build's broken right now due to test harness stuff; I'll be fixing up the build later today |
bdero
force-pushed
the
bdero/vulkan-embedder
branch
from
46ad11b
to
8ae6fa2
Compare
chinmaygarde
changed the title
|
@bdero thanks for your hard work on this. I will start working with this on Monday. |
bdero
force-pushed
the
bdero/vulkan-embedder
branch
2 times, most recently
from
8b91867
to
55f571a
Compare
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Dec 2, 2021
…) to add missing implementations in SubzeroReactor.cpp. Corresponding buildroot PR: flutter/buildroot#529 Needed for flutter#29391.
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Dec 2, 2021
…) to add missing implementations in SubzeroReactor.cpp. Corresponding buildroot PR: flutter/buildroot#529 Needed for flutter#29391. (cherry picked from commit dca7211)
bdero
force-pushed
the
bdero/vulkan-embedder
branch
from
1de7ccd
to
184c2a7
Compare
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Dec 2, 2021
…) to add missing implementations in SubzeroReactor.cpp. Corresponding buildroot PR: flutter/buildroot#529 Needed for flutter#29391.
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Dec 2, 2021
…) to add missing implementations in SubzeroReactor.cpp. Corresponding buildroot PR: flutter/buildroot#529 Needed for flutter#29391.
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Dec 2, 2021
…) to add missing implementations in SubzeroReactor.cpp. Corresponding buildroot PR: flutter/buildroot#529 Needed for flutter#29391.
bdero
force-pushed
the
bdero/vulkan-embedder
branch
from
cae71d3
to
63f0b5f
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look and see if the
embedder.hAPI looks like it works for your use case. /cc @jwinarske @arbreng @chinmaygardeSee
FlutterVulkanBackingStore.imageandFlutterVulkanRendererConfig.get_next_image_callback/present_image_callbackfor a full description of the default synchronization behavior for both the layer and root image writing cases respectively (the behavior is essentially the same).My thought is that by default, we can simply have the engine internally host sync (with VkFences) before calling "present" callbacks. This matches the Fuchsia embedder's current behavior.
Later on, we can enable embedders to take full control over synchronization by adding an optional
FlutterVulkanImage.semaphorefield that, when present, will trigger the engine to automatically disable the default fence+present callback behavior, and the engine will instead signal the semaphore on device after pipeline execution. If the embedder provides a semaphore, the embedder can then submit pipeline commands ahead of time that will start executing on device immediately after the engine is done writing the image, eliminating an unnecessary device->host sync + host->device queue submit from the rendering time in cases where it's not desirable to render directly into swapchain images.