Move the WindowInsetsAnimation.Callback implementation to an inner class to avoid Android class loader warnings #22916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass to avoid Android class loader warnings ImeSyncDeferringInsetsCallback had been a subclass of WindowInsetsAnimation.Callback, which was introduced in Android API level 30. The class loader on older versions of Android was logging warnings about unresolvable classes when loading TextInputPlugin, which holds a reference to ImeSyncDeferringInsetsCallback. See flutter/flutter#66908
jason-simmons
force-pushed
the
bug_66908_b
branch
from
5ba0504
to
b635073
Compare
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2020
…inner class to avoid Android class loader warnings (flutter/engine#22916)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2020
…inner class to avoid Android class loader warnings (flutter/engine#22916)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2020
…inner class to avoid Android class loader warnings (flutter/engine#22916)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2020
…inner class to avoid Android class loader warnings (flutter/engine#22916)
langys
pushed a commit
to langys/engine
that referenced
this pull request
May 22, 2022
…ass to avoid Android class loader warnings (flutter#22916)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImeSyncDeferringInsetsCallback had been a subclass of WindowInsetsAnimation.Callback,
which was introduced in Android API level 30. The class loader on
older versions of Android was logging warnings about unresolvable
classes when loading TextInputPlugin, which holds a reference to
ImeSyncDeferringInsetsCallback.
See flutter/flutter#66908