Extract the WindowInsetsAnimation.Callback subclass into a separate class that will be lazily loaded #21548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
force-pushed
the
bug_66908
branch
from
d763bf7
to
700c7ca
Compare
GaryQian
reviewed
Oct 1, 2020
| this.view = view; | ||
| } | ||
|
|
||
| void install() { |
GaryQian
reviewed
Oct 1, 2020
| view.setOnApplyWindowInsetsListener(this); | ||
| } | ||
|
|
||
| void remove() { |
…lass that will be lazily loaded WindowInsetsAnimation.Callback was introduced in API level 30. This PR moves the text input plugin's WindowInsetsAnimation.Callback subclass into a class that will only be loaded if the embedding has checked for a sufficient API level. See flutter/flutter#66908
jason-simmons
force-pushed
the
bug_66908
branch
from
700c7ca
to
9c524a6
Compare
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
…parate class that will be lazily loaded (flutter/engine#21548)
christopherfujino
pushed a commit
to christopherfujino/engine
that referenced
this pull request
Oct 7, 2020
…lass that will be lazily loaded (flutter#21548) WindowInsetsAnimation.Callback was introduced in API level 30. This PR moves the text input plugin's WindowInsetsAnimation.Callback subclass into a class that will only be loaded if the embedding has checked for a sufficient API level. See flutter/flutter#66908
christopherfujino
added a commit
that referenced
this pull request
Oct 7, 2020
* Update Dart to 2.10.1 * Extract the WindowInsetsAnimation.Callback subclass into a separate class that will be lazily loaded (#21548) WindowInsetsAnimation.Callback was introduced in API level 30. This PR moves the text input plugin's WindowInsetsAnimation.Callback subclass into a class that will only be loaded if the embedding has checked for a sufficient API level. See flutter/flutter#66908 * iOS: only add explicit transactions when there are platform views (only on main threads) (#21526) * update licenses golden * pin framework for build tests Co-authored-by: Jason Simmons <[email protected]> Co-authored-by: Chris Yang <[email protected]>
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Oct 20, 2020
…lass that will be lazily loaded (flutter#21548) WindowInsetsAnimation.Callback was introduced in API level 30. This PR moves the text input plugin's WindowInsetsAnimation.Callback subclass into a class that will only be loaded if the embedding has checked for a sufficient API level. See flutter/flutter#66908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WindowInsetsAnimation.Callback was introduced in API level 30. This
PR moves the text input plugin's WindowInsetsAnimation.Callback subclass
into a class that will only be loaded if the embedding has checked for a
sufficient API level.
See flutter/flutter#66908