Skip to content

Commit

Permalink
[Impeller] Include cstdint everywhere that uint32_t is used. (#47533)
Browse files Browse the repository at this point in the history
Sprinkle cstdint everywhere that it's used. Unblocks the next impeller-cmake bump.

Ran into include issues during the build for the most recent impeller-cmake bump: bdero/impeller-cmake#20

Going to add an optional libcxx STL build to help avoid stuff like this later (in the AAOS action items).
  • Loading branch information
bdero authored Nov 1, 2023
1 parent 0c53706 commit a0ac6b4
Show file tree
Hide file tree
Showing 38 changed files with 53 additions and 3 deletions.
1 change: 1 addition & 0 deletions impeller/base/allocation.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <limits>
#include <memory>

Expand Down
1 change: 1 addition & 0 deletions impeller/compiler/compiler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#include "impeller/compiler/compiler.h"

#include <cstdint>
#include <filesystem>
#include <memory>
#include <optional>
Expand Down
1 change: 1 addition & 0 deletions impeller/compiler/compiler_backend.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <memory>
#include <variant>

Expand Down
1 change: 1 addition & 0 deletions impeller/compiler/reflector.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <memory>
#include <optional>

Expand Down
1 change: 1 addition & 0 deletions impeller/compiler/runtime_stage_data.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "impeller/compiler/runtime_stage_data.h"

#include <array>
#include <cstdint>
#include <optional>

#include "inja/inja.hpp"
Expand Down
1 change: 1 addition & 0 deletions impeller/compiler/source_options.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <memory>
#include <string>
#include <vector>
Expand Down
1 change: 1 addition & 0 deletions impeller/compiler/spirv_compiler.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <vector>

#include "flutter/fml/macros.h"
Expand Down
1 change: 1 addition & 0 deletions impeller/compiler/spirv_sksl.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <memory>
#include <utility>
#include <variant>
Expand Down
1 change: 1 addition & 0 deletions impeller/compiler/switches.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <iostream>
#include <memory>

Expand Down
2 changes: 2 additions & 0 deletions impeller/compiler/uniform_sorter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#include "impeller/compiler/uniform_sorter.h"

#include <cstdint>

namespace impeller {

std::vector<spirv_cross::ID> SortUniforms(
Expand Down
1 change: 1 addition & 0 deletions impeller/core/shader_types.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#pragma once

#include <cstddef>
#include <cstdint>
#include <optional>
#include <string_view>
#include <vector>
Expand Down
5 changes: 2 additions & 3 deletions impeller/entity/entity.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@

#pragma once

#include <variant>
#include <cstdint>

#include "impeller/core/capture.h"
#include "impeller/entity/contents/contents.h"
#include "impeller/geometry/color.h"
#include "impeller/geometry/matrix.h"
#include "impeller/geometry/path.h"
#include "impeller/geometry/rect.h"
#include "impeller/image/decompressed_image.h"

namespace impeller {

Expand Down
1 change: 1 addition & 0 deletions impeller/entity/entity_pass.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <functional>
#include <memory>
#include <optional>
Expand Down
2 changes: 2 additions & 0 deletions impeller/entity/inline_pass_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#pragma once

#include <cstdint>

#include "impeller/entity/entity_pass_target.h"
#include "impeller/renderer/context.h"
#include "impeller/renderer/render_pass.h"
Expand Down
1 change: 1 addition & 0 deletions impeller/geometry/color.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <stdint.h>
#include <algorithm>
#include <array>
#include <cstdint>
#include <cstdlib>
#include <ostream>
#include <type_traits>
Expand Down
1 change: 1 addition & 0 deletions impeller/geometry/gradient.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <memory>
#include <vector>

Expand Down
1 change: 1 addition & 0 deletions impeller/geometry/point.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

#include <algorithm>
#include <cmath>
#include <cstdint>
#include <ostream>
#include <string>
#include <type_traits>
Expand Down
1 change: 1 addition & 0 deletions impeller/renderer/backend/gles/device_buffer_gles.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <memory>

#include "flutter/fml/macros.h"
Expand Down
1 change: 1 addition & 0 deletions impeller/renderer/backend/gles/gpu_tracer_gles.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <deque>
#include <thread>

Expand Down
2 changes: 2 additions & 0 deletions impeller/renderer/backend/gles/render_pass_gles.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#include "impeller/renderer/backend/gles/render_pass_gles.h"

#include <cstdint>

#include "GLES3/gl3.h"
#include "flutter/fml/trace_event.h"
#include "fml/closure.h"
Expand Down
1 change: 1 addition & 0 deletions impeller/renderer/backend/vulkan/allocator_vk.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include "impeller/renderer/backend/vulkan/vk.h"

#include <array>
#include <cstdint>
#include <memory>

namespace impeller {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
// found in the LICENSE file.

#include "impeller/renderer/backend/vulkan/android_hardware_buffer_texture_source_vk.h"

#include <cstdint>

#include "impeller/renderer/backend/vulkan/texture_source_vk.h"

#ifdef FML_OS_ANDROID
Expand Down
2 changes: 2 additions & 0 deletions impeller/renderer/backend/vulkan/blit_command_vk.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#include "impeller/renderer/backend/vulkan/blit_command_vk.h"

#include <cstdint>

#include "impeller/renderer/backend/vulkan/command_encoder_vk.h"
#include "impeller/renderer/backend/vulkan/texture_vk.h"

Expand Down
1 change: 1 addition & 0 deletions impeller/renderer/backend/vulkan/capabilities_vk.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <map>
#include <set>
#include <string>
Expand Down
1 change: 1 addition & 0 deletions impeller/renderer/backend/vulkan/command_encoder_vk.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <functional>
#include <optional>

Expand Down
2 changes: 2 additions & 0 deletions impeller/renderer/backend/vulkan/descriptor_pool_vk.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#pragma once

#include <cstdint>

#include "flutter/fml/macros.h"
#include "fml/status_or.h"
#include "impeller/renderer/backend/vulkan/device_holder.h"
Expand Down
2 changes: 2 additions & 0 deletions impeller/renderer/backend/vulkan/formats_vk.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#pragma once

#include <cstdint>

#include "flutter/fml/macros.h"
#include "impeller/base/validation.h"
#include "impeller/core/formats.h"
Expand Down
1 change: 1 addition & 0 deletions impeller/renderer/backend/vulkan/pass_bindings_cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <optional>

#include "flutter/impeller/renderer/backend/vulkan/vk.h"
Expand Down
1 change: 1 addition & 0 deletions impeller/renderer/backend/vulkan/pipeline_library_vk.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "impeller/renderer/backend/vulkan/pipeline_library_vk.h"

#include <chrono>
#include <cstdint>
#include <optional>
#include <sstream>

Expand Down
2 changes: 2 additions & 0 deletions impeller/renderer/backend/vulkan/shader_library_vk.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#include "impeller/renderer/backend/vulkan/shader_library_vk.h"

#include <cstdint>

#include "flutter/fml/logging.h"
#include "flutter/fml/trace_event.h"
#include "impeller/renderer/backend/vulkan/context_vk.h"
Expand Down
1 change: 1 addition & 0 deletions impeller/renderer/backend/vulkan/swapchain_impl_vk.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <memory>
#include <variant>

Expand Down
3 changes: 3 additions & 0 deletions impeller/renderer/backend/vulkan/test/mock_vulkan.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@
// found in the LICENSE file.

#include "impeller/renderer/backend/vulkan/test/mock_vulkan.h"

#include <cstdint>
#include <cstring>
#include <utility>
#include <vector>

#include "fml/macros.h"
#include "fml/thread_local.h"
#include "impeller/base/thread_safety.h"
Expand Down
2 changes: 2 additions & 0 deletions impeller/renderer/backend/vulkan/vertex_descriptor_vk.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#include "impeller/renderer/backend/vulkan/vertex_descriptor_vk.h"

#include <cstdint>

namespace impeller {

vk::Format ToVertexDescriptorFormat(const ShaderStageIOSlot& input) {
Expand Down
1 change: 1 addition & 0 deletions impeller/renderer/command.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <map>
#include <memory>
#include <optional>
Expand Down
2 changes: 2 additions & 0 deletions impeller/renderer/compute_tessellator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#include "impeller/renderer/compute_tessellator.h"

#include <cstdint>

#include "impeller/renderer/command_buffer.h"
#include "impeller/renderer/path_polyline.comp.h"
#include "impeller/renderer/pipeline_library.h"
Expand Down
1 change: 1 addition & 0 deletions impeller/renderer/pool.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <cstdint>
#include <memory>
#include <mutex>

Expand Down
1 change: 1 addition & 0 deletions impeller/scene/importer/vertices_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#include "impeller/scene/importer/vertices_builder.h"

#include <cstdint>
#include <cstring>
#include <limits>
#include <memory>
Expand Down
2 changes: 2 additions & 0 deletions impeller/tessellator/c/tessellator.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#pragma once

#include <cstdint>

#include "impeller/geometry/path_builder.h"
#include "impeller/tessellator/tessellator.h"

Expand Down

0 comments on commit a0ac6b4

Please sign in to comment.