Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where socket profile data was being displayed as web socket connections #8061

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jul 16, 2024

Socket data is now displayed correctly, with method set to SOCKET and type displaying the socket type (e.g., TCP vs UDP).

Fixes #3033

image

@bkonyi bkonyi requested review from kenzieschmoll and a team as code owners July 16, 2024 00:14
@kenzieschmoll
Copy link
Member

Please add release notes for this change with a screenshot (preferably a smaller one than is in the PR description since this will be shown in DevTools release notes).

Also, can you change the "Uri" column to "address" instead? I think that would better encompass both Socket traffic and Http traffic.

Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass!

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2024
Copy link

auto-submit bot commented Jul 17, 2024

auto label is removed for flutter/devtools/8061, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 3/3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi merged commit f440b48 into flutter:master Jul 17, 2024
25 checks passed
@bkonyi bkonyi deleted the fix_socket_profiler branch July 17, 2024 03:54
@laterdayi
Copy link

Thanks for your help, how should I update, can't wait to use this feature

kenzieschmoll pushed a commit to kenzieschmoll/devtools that referenced this pull request Jul 17, 2024
… connections (flutter#8061)

* Fix issue where socket profile data was being displayed as web socket connections

Fixes flutter#3033
@bkonyi
Copy link
Contributor Author

bkonyi commented Jul 17, 2024

Thanks for your help, how should I update, can't wait to use this feature

Right now you'll need to be using the Flutter main branch on a commit that includes the updated Dart SDK. The changes might not have rolled all the way to Flutter yet, so your safest bet is to wait for the next beta release which includes these changes which will hopefully happen in the next week or two.

Piinks pushed a commit that referenced this pull request Aug 5, 2024
* Fix overlapping UI on disconnect (#8057)

* Fix issue where socket profile data was being displayed as web socket connections (#8061)

* Fix issue where socket profile data was being displayed as web socket connections

Fixes #3033

* Prepare cherry-pick release - DevTools 2.37.2

---------

Co-authored-by: Ben Konyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normal socket wrongly named WebSocket
3 participants