Switch back to dart:html for postMessage #7476
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for dart-lang/sdk#54938 because the
package:web
version ofpostMessage
causes security exceptions.Fixes Dart-Code/Dart-Code#5049
@kenzieschmoll @jacob314 I verified running DevTools from source had the issue shown in the bug above, and with this change it can communicate with VS Code correctly:
I don't know if a release has been made for the next beta already, but if so this might need to be included (I'm assuming dart-lang/sdk#54938 won't be fixed before then.. if it is, we can ofcourse drop this).
I don't know if there are other implications of using
dart:html
here (since work had been done to remove it).(This also reinforces that we need a better way to test all of this end-to-end against bleeding-edge code!).