[Inspector V2] Add a border around the message that no widget is sele…

…cted (#8524)
flutter · Nov 21, 2024 · 7ce5efa · 7ce5efa
1 parent 77612d2
commit 7ce5efa
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/packages/devtools_app/lib/src/screens/inspector_v2/widget_details.dart b/packages/devtools_app/lib/src/screens/inspector_v2/widget_details.dart
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import 'package:devtools_app_shared/ui.dart';
 import 'package:devtools_app_shared/utils.dart';
 import 'package:flutter/widgets.dart';
 
@@ -38,19 +39,18 @@ class _WidgetDetailsState extends State<WidgetDetails> with AutoDisposeMixin {
       builder: (context, _, _) {
         final node = selectedNode;
         if (node == null) {
-          return const Center(
-            child: Text(
-              'Select a widget to view its layout and properties.',
-              textAlign: TextAlign.center,
-              overflow: TextOverflow.clip,
+          return const RoundedOutlinedBorder(
+            child: Center(
+              child: Text(
+                'Select a widget to view its layout and properties.',
+                textAlign: TextAlign.center,
+                overflow: TextOverflow.clip,
+              ),
             ),
           );
         }
 
-        return DetailsTable(
-          controller: controller,
-          node: node,
-        );
+        return DetailsTable(controller: controller, node: node);
       },
     );
   }

diff --git a/..._app/test/test_infra/goldens/integration_inspector_v2_errors_1_initial_load.png b/..._app/test/test_infra/goldens/integration_inspector_v2_errors_1_initial_load.png
diff --git a/...test_infra/goldens/integration_inspector_v2_implementation_widgets_expanded.png b/...test_infra/goldens/integration_inspector_v2_implementation_widgets_expanded.png
diff --git a/.../devtools_app/test/test_infra/goldens/integration_inspector_v2_initial_load.png b/.../devtools_app/test/test_infra/goldens/integration_inspector_v2_initial_load.png
diff --git a/...s/devtools_app/test/test_infra/goldens/memory/load_offline_data_profile_tab.png b/...s/devtools_app/test/test_infra/goldens/memory/load_offline_data_profile_tab.png
diff --git a/packages/devtools_app/test/test_infra/goldens/memory_diff_empty1.png b/packages/devtools_app/test/test_infra/goldens/memory_diff_empty1.png
diff --git a/packages/devtools_app/test/test_infra/goldens/memory_diff_empty2.png b/packages/devtools_app/test/test_infra/goldens/memory_diff_empty2.png