Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WebImage to OptionalImage to avoid name conflict #4040

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Rename WebImage to OptionalImage to avoid name conflict #4040

merged 3 commits into from
Nov 19, 2024

Conversation

harryterkelsen
Copy link
Contributor

Renames WebImage to OptionalImage to avoid naming conflicts with the upcoming WebImage widget in the Flutter Framework.

This fixes the "customer_tests" suite in the WebImage PR in the framework: flutter/flutter#157755

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

yjbanov
yjbanov approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtmcdole
Copy link
Contributor

120 line length format:

  • dart format --set-exit-if-changed --line-length=120 . lib/ test/

@harryterkelsen harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App. label Nov 19, 2024
@auto-submit auto-submit bot merged commit 5bc3916 into main Nov 19, 2024
4 checks passed
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label Nov 19, 2024
@harryterkelsen harryterkelsen mentioned this pull request Nov 19, 2024
Merged
8 tasks
auto-submit bot pushed a commit to flutter/tests that referenced this pull request Nov 19, 2024
@harryterkelsen
Roll cocoon tests to 5bc3916e16d57d5233a26a3d6dfcce317538f3b5 (#429)
3deeb2d 
Rolls the cocoon checkout to 5bc3916e16d57d5233a26a3d6dfcce317538f3b5 so it picks up the fix here: flutter/cocoon#4040

This allows flutter/flutter#157755 to land without breaking customer tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harryterkelsen @jtmcdole @yjbanov