Added show user location and tracking for iOS #76
Conversation
* Added support for sideloading map tiles
|
This is great stuff @kayleg. Thank you for contributing! |
lib/src/controller.dart
Outdated
| @@ -37,21 +40,24 @@ class MapboxMapController extends ChangeNotifier { | |||
| static Future<MapboxMapController> init( | |||
| int id, CameraPosition initialCameraPosition, | |||
| {OnMapClickCallback onMapClick, | |||
| OnCameraTrackingDismissedCallback onCameraTrackingDismissed}) async { | |||
| OnCameraTrackingDismissedCallback onCameraTrackingDismissed, | |||
| onCameraTrackingChanged}) async { | |||
There was a problem hiding this comment.
Add OnCameraTrackingChangedCallback type to onCameraTrackingChanged
| private func updateMyLocationEnabled() { | ||
| //TODO | ||
| mapView.showsUserLocation = self.myLocationEnabled | ||
| mapView.userTrackingMode = .followWithHeading |
There was a problem hiding this comment.
remove this line mapView.userTrackingMode = .followWithHeading
There was a problem hiding this comment.
Same as @andrea689. The user tracking mode is set by a different method.
|
|
||
| func mapView(_ mapView: MGLMapView, didChange mode: | ||
| MGLUserTrackingMode, animated: Bool) { | ||
| channel.invokeMethod("map#onCameraTrackingChanged", arguments: ["mode": mode.rawValue]) |
There was a problem hiding this comment.
Given that iOS don't have onCameraTrackingDismissed, to maintain compatibility with Android when mode is equals to MGLUserTrackingModeNone invoke this method map#onCameraTrackingDismissed
|
@TimothySealy would you be able to give this PR a review? |
* Passing map style to iOS map (MGLMapView). * Moved map style lookup table to a separate file. * Renamed style parameter to styleString. * Moved the lookup behind a fromUrl function. * Added checks for empty styleString and JSON styleStrings. * Updated minimum Android SDK version to 20 (this required for flutter platform views). * Updated mapbox SDK for Android. Updated code to make it compatible with the new SDK. * Updated Mabox SDk for iOS * Replaced zIndex with SymbolSortKey.
| private func updateMyLocationEnabled() { | ||
| //TODO | ||
| mapView.showsUserLocation = self.myLocationEnabled | ||
| mapView.userTrackingMode = .followWithHeading |
There was a problem hiding this comment.
Same as @andrea689. The user tracking mode is set by a different method.
|
Requested changes have been made |
Added support for
myLocationandmyLocationTrackingModefor iOS.Added a new callback for
onCameraTrackingModeChanged(iOS doesn't have a simple dismissed)Note:
I'm fairly new to Flutter and this was my first go at connecting to native code. I followed the existing setup.