Add symbol API #25
Add symbol API #25
Conversation
|
In the last two commits, I have added support for:
The main thing that needs to be fixed before calling this feature ready is correctly handling state. Atm if you have update the rotation to say 270 degrees and change the opacity. It will reset the rotation to 0 instead of keeping the old value applied. |
|
Was able to track down where the symbol update is going wrong. Instead of providing default options as how Google Maps Flutter Plugin is doing, we need to provide default values during conversion time in the dart code. Reason is that the Mapbox Annotation Plugin is different as the Marker API on Google Maps SDK. |
|
Here is an example of it working:
While it works for this specific case, I need to go through the whole API surface and make sure it works correctly. |
| @@ -48,7 +49,7 @@ public void setCompassEnabled(boolean compassEnabled) { | |||
|
|
|||
| @Override | |||
| public void setCameraTargetBounds(LatLngBounds bounds) { | |||
| Log.e(TAG,"setCameraTargetBounds is supported only after map initiated."); | |||
| Log.e(TAG, "setCameraTargetBounds is supported only after map initiated."); | |||
There was a problem hiding this comment.
yes correct, delete for now?
There was a problem hiding this comment.
I think we should keep it, but I though you may think differently and wanted to point it out.
android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/mapbox/mapboxgl/SymbolController.java
Outdated
Show resolved
Hide resolved
|
@yoavrofe thank you for the review and apologies for the delay (I was on holiday). I revisited this PR with your comments. Could you take another look? |
WIP, not ready for review yet. Closes #11
A symbol is the Mapbox equivalent of Google Marker.
See more information in the style-spec here.
Most of the code in this PR is created using the code generator of https://github.com/mapbox/mapbox-plugins-android/tree/master/plugin-annotation. Once this API for symbol lands we can easily extend with with circles, fills and lines.
Current state is generating all code + showing a simple symbol:
cc @yoavrofe