Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messaging around missing access token #91

Closed
Cliabhach opened this issue Aug 5, 2019 · 0 comments · Fixed by #117
Closed

Improve error messaging around missing access token #91

Cliabhach opened this issue Aug 5, 2019 · 0 comments · Fixed by #117
Assignees
Labels
Milestone

Comments

@Cliabhach
Copy link

This specifically concerns the android part of this library. May belong under #40 , but I thought I'd open a new issue just in case.

I accidentally placed an access token in the wrong part of my android project's AndroidManifest. It was only when I noticed the NullPointerException error from https://github.com/tobrun/flutter-mapbox-gl/blob/26e3fec19e165cd3dcd6383555e5e99cbe2c08f5/android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java#L135-L139 in the logs and cross-referenced that with the README.md text that I discovered my mistake.

I suggest that those log messages should instead say something like

Failed to find an Access Token in the Application meta-data. MapBox may not load correctly. Please refer to the installation guide at (url goes here) for troubleshooting advice.

@tobrun tobrun added this to the v0.0.5 milestone Nov 10, 2019
@tobrun tobrun added the android label Nov 10, 2019
@tobrun tobrun self-assigned this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants