Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry opt out for compliance with Mapbox Terms of Service #143

Closed
m0nac0 opened this issue Dec 12, 2019 · 1 comment · Fixed by #144
Closed

Telemetry opt out for compliance with Mapbox Terms of Service #143

m0nac0 opened this issue Dec 12, 2019 · 1 comment · Fixed by #144

Comments

@m0nac0
Copy link
Collaborator

m0nac0 commented Dec 12, 2019 •
edited
Loading

According to https://docs.mapbox.com/android/maps/overview/#telemetry-opt-out app developers are required to provide users with the possibility to opt out of the collection of anonymized location and usage data.
Normally this seems to be possible by clicking the Mapbox attribution, (at least on Android) that doesn't work with this plugin, though. I don't know whether this works on iOS or not.
It would probably be sufficient to add a method to the MapboxMapController to enable/disable the collection of telemetry data.
@m0nac0 m0nac0 mentioned this issue Dec 12, 2019
Merged
@TimothySealy
Copy link
Collaborator

Hi @m0nac0,

Attribution has been disabled in Android (#12) because clicking on the info icon cause the app to crash. In iOS attribution is implemented and via the info icon it is possible for the end user to opt-out of telemetry. I think fixing attribution in Android (tracked by issue #13) would be the way forward here.

Having said that I think it is a good idea to have the option to programmatically enable/disable telemetry as an additional feature (and workaround for Android). I'll have a look at your PR for the iOS implementation.

tobrun added a commit that referenced this issue Jan 10, 2020
@m0nac0 @TimothySealy @tobrun
Implement setTelemetryEnabled for Android (Fix #143) (#144)
b27e2f6 
* Add setTelemetryEnabled support for Android

* Ignore setTelemetryEnabled on iOS

* Update MapboxMapController.swift

Fix formatting on iOS

* Implement matchMapLanguageWithDeviceDefault and setMapLanguage on Android

Implement matchMapLanguageWithDeviceDefault and setMapLanguage on Android through the Mapbox Localization Plugin for Android
On iOS these function calls are ignored

* Fix android implementation

* Revert "Merge branch 'all_features' into telemetry"

This reverts commit 078eefd, reversing
changes made to 5e7fd88.

* Add example code for setTelemetryEnabled

* Setting the required MGLMapboxMetricsEnabledSettingShownInApp property in the plist.

* Implemented "map#getTelemetryEnabled" and "map#setTelemertyEnabled".

* Added getTelemetryEnabled to controller.

* Read whether telemetry has been enabled when opening the map ui page.

* Implement getTelemetryEnabled on Android

Co-authored-by: Timothy Sealy <[email protected]>
Co-authored-by: Tobrun <[email protected]>
Lobankovanastia pushed a commit to Lobankovanastia/flutter-mapbox-gl that referenced this issue Feb 15, 2020
@m0nac0 @TimothySealy @tobrun
Implement setTelemetryEnabled for Android (Fix flutter-mapbox-gl#143) (…
ed98d97 
…flutter-mapbox-gl#144)

* Add setTelemetryEnabled support for Android

* Ignore setTelemetryEnabled on iOS

* Update MapboxMapController.swift

Fix formatting on iOS

* Implement matchMapLanguageWithDeviceDefault and setMapLanguage on Android

Implement matchMapLanguageWithDeviceDefault and setMapLanguage on Android through the Mapbox Localization Plugin for Android
On iOS these function calls are ignored

* Fix android implementation

* Revert "Merge branch 'all_features' into telemetry"

This reverts commit 078eefd, reversing
changes made to 5e7fd88.

* Add example code for setTelemetryEnabled

* Setting the required MGLMapboxMetricsEnabledSettingShownInApp property in the plist.

* Implemented "map#getTelemetryEnabled" and "map#setTelemertyEnabled".

* Added getTelemetryEnabled to controller.

* Read whether telemetry has been enabled when opening the map ui page.

* Implement getTelemetryEnabled on Android

Co-authored-by: Timothy Sealy <[email protected]>
Co-authored-by: Tobrun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement setTelemetryEnabled for Android (Fix #143)
2 participants
@TimothySealy @m0nac0