-
Notifications
You must be signed in to change notification settings - Fork 63
Implementing Web support #51
base: main
Are you sure you want to change the base?
Conversation
@@ -11,16 +11,27 @@ environment: | |||
dependencies: | |||
flutter: | |||
sdk: flutter | |||
flutter_web_plugins: | |||
sdk: flutter | |||
js: ^0.6.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to indented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to me that it is necessary to be indented as it is written in How to Write a Flutter Web Plugin:
name: url_launcher_web
version: 0.0.1
flutter:
plugin:
platforms:
web:
pluginClass: UrlLauncherPlugin
fileName: url_launcher_web.dart
dependencies:
flutter:
sdk: flutter
flutter_web_plugins:
sdk: flutter
environment:
sdk: ">=2.0.0-dev.28.0 <3.0.0"
flutter: ">=1.5.0 <2.0.0"
I'm still new in flutter development and I always saw dependencies indented therefore I'm sorry if I'm misunderstanding your question.
I also read this :
"Each node must be indented further than its parent node. All sibling nodes must use the exact same indentation level. However the content of each sibling node may be further indented independently. "
(YAML Specs v1.2 3rd edition.)
Doesn't know if this can help you but js package is on pub.dev (and allows to call js API in dart code) while flutter_web_plugins is in the flutter API (and provides the Registrar class implementing for web implementations).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to make sure we are not having the js dependency in my mobile apps that do not use web.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, as one can read here : https://developer.android.com/studio/build/shrink-code
The unused dependencies are shrink at compile time when creating a release.
So don't worry to much about this JS deps. It will ultimately be removed when creating any release of a mobile application.
Hi there! Sorry for the late reply.. |
Hello, |
I find the problem and fix it (I was forcing regionCode to not be null when parsing international phone numbers). I find two other issues :
|
Hey all, is this planned on being merged soon? |
Is there any update on this merge? |
Take a look on this @gabriel8belts #86 |
This pull request is linked to issue #44.
Here you can find, an implementation of your plugin for web using google libphonenumber js library using https://github.com/natintosh/plugin_libphonenumber/tree/develop/libphonenumber_web as a starting point.
There is a deprecated call on MethodChannel constructor with Registrar.messenger, but I failed to get the plugin to work without using it.