Updates to CI and code cleanup

[martijn00]

Solution description

Closes:

• form_builder_validator is not compatible with intl. 0.19.0 #73
• Upgrade intl dependency to 0.19 #76
• build(deps): bump flutter_lints from 2.0.3 to 3.0.2 #80
• build(deps): bump codecov/codecov-action from 3 to 4 #77
• [General]: Incompatible with Flutter 3.22 due to dependency on intl 0.18.1 #90

I've used this opportunity to also cleanup some code and CI. Let me know if i need to change anything.

It might be necessary to run flutter gen-l10n as a build step, but i can validate that once you approve running this PR.

Screenshots or Videos

To Do

• Read contributing guide
• Check the original issue to confirm it is fully satisfied
• Add solution description to help guide reviewers
• Add unit test to verify new or fixed behaviour
• If apply, add documentation to code properties and package readme

[deandreamatias]

Thanks a lot for contribution! Is something really necessary.

About the PR, the intl generated files are necessary because this package has embedded the translation of validations. So, I think that is necessary not ignore the generated files from git.

[martijn00]

I'll get back on this as soon as I am back from holiday. Still the intl files are not necessary because they will be generated by a build step. After that step it will indeed be included in the package.

[martijn00]

@deandreamatias Can you run the workflow for CI again?

[bkozik]

Hiya @martijn00 @deandreamatias. I'm having some trouble trying to use this as we wait for it to be merged. Specifically, nullsafety issues having to do with you removing the ! from the nullable string passed to RegExp.hasMatch in a few places. hasMatch requires a String not a String?, and the shift method still returns T? nullable, the user var is still String?.

I'm not sure how it's building on your ends?

Any help would be appreciated, let me know if you need more information or if I'm missing something! Hopefully the below screenshots help

The error:

The problem:

Nothing else changed to make this non-nullable:

https://api.flutter.dev/flutter/dart-core/RegExp/hasMatch.html

[martijn00]

@bkozik Good catch, i've added a fix for this now. Can you test it?

[martijn00]

@deandreamatias is it possible that you enable a setting to build updates to a PR in CI automatically without approval every time?

[deandreamatias]

I think that need update the readme section about contribute with languages https://github.com/flutter-form-builder-ecosystem/form_builder_validators?tab=readme-ov-file#add-new-supported-language

[deandreamatias]

About the last error, maybe is because this line flutter build ios --debug --no-codesign. The debug is not used anymore by Flutter? I do not know

[martijn00]

@deandreamatias Aah this is because i moved to building on Linux. Do you think i should move it back to MacOS or is it fine for you to only test if Android builds?

I've committed a chance to only do Android, let me know if that works for you, or i will revert back to Mac.

[martijn00]

@deandreamatias This seems good to go now. Can you merge and make the release?