Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1434 Replace dropdown #1451

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented Dec 26, 2024

Connection with issue(s)

Close #1402
Close #1371

Connected to #???

Solution description

Replace a Dropdown that inclue a FormState to other with only the design logic

Screenshots or Videos

Screencast.from.2024-12-26.19-10-16.webm

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@deandreamatias deandreamatias changed the title Bugfix/1434-initial-value-state fix:#1434-dropdown-fix Dec 26, 2024
@deandreamatias deandreamatias changed the title fix:#1434-dropdown-fix fix: #1434 Replace dropdown Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.15%. Comparing base (1c9acc8) to head (be613d1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1451      +/-   ##
==========================================
+ Coverage   88.11%   88.15%   +0.04%     
==========================================
  Files          21       21              
  Lines         774      777       +3     
==========================================
+ Hits          682      685       +3     
  Misses         92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deandreamatias deandreamatias merged commit 6f6b567 into main Dec 26, 2024
9 of 11 checks passed
@deandreamatias deandreamatias deleted the bugfix/1434-initial-value-state branch December 26, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant