fix: DateTime Picker "cancel" button behavior fix #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please @geronimol, update the code to pass the Base pipeline. Thanks! |
deandreamatias
added
the
awaiting author response
geronimol
force-pushed
the
date-picker-cancel-behavior
branch
from
05b9945 to
2dbd891
Compare
Bumps [flutter_lints](https://github.com/flutter/packages/tree/main/packages) from 4.0.0 to 5.0.0. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/flutter_lints-v5.0.0/packages) --- updated-dependencies: - dependency-name: flutter_lints dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
geronimol
force-pushed
the
date-picker-cancel-behavior
branch
from
2dbd891 to
f39fa6d
Compare
geronimol
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1444 +/- ##
==========================================
+ Coverage 87.82% 88.11% +0.28%
==========================================
Files 21 21
Lines 772 774 +2
==========================================
+ Hits 678 682 +4
+ Misses 94 92 -2 ☔ View full report in Codecov by Sentry. |
geronimol
changed the title
|
@deandreamatias not sure how to fix this |
deandreamatias
merged commit 08ccbc9
into
flutter-form-builder-ecosystem:main
5 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution description
Currently, the DateTime Picker is picking the date+time even when the user presses "cancel" in the time picker dialog.
This will change that behavior so if the user presses the "cancel" button, the selections he made will not be saved in the field.
Screenshots or Videos
To Do