Merge pull request #1342 from lreardon/patch-1

Reintroduce ability to validate form field's value independent of input's error text
flutter-form-builder-ecosystem · Jan 5, 2024 · ba065e5 · ba065e5
2 parents 04660f1 + 6e55bbf
commit ba065e5
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 0 deletions.
diff --git a/lib/src/form_builder_field.dart b/lib/src/form_builder_field.dart
@@ -99,6 +99,9 @@ class FormBuilderFieldState<F extends FormBuilderField<T>, T>
   @override
   bool get isValid => super.isValid && errorText == null;
 
+  bool get valueIsValid => super.isValid;
+  bool get valueHasError => super.hasError;
+
   bool get enabled => widget.enabled && (_formBuilderState?.enabled ?? true);
   bool get readOnly => !(_formBuilderState?.widget.skipDisabled ?? false);
   bool get _isAlwaysValidate =>

diff --git a/test/src/form_builder_field_test.dart b/test/src/form_builder_field_test.dart
@@ -125,6 +125,46 @@ void main() {
       });
     });
 
+    group('valueIsValid -', () {
+      testWidgets(
+          'Should value is valid when validator passes, despite set custom error',
+          (tester) async {
+        final textFieldKey = GlobalKey<FormBuilderFieldState>();
+        const textFieldName = 'text';
+        const errorTextField = 'error text field';
+        final testWidget = FormBuilderTextField(
+          name: textFieldName,
+          key: textFieldKey,
+        );
+        await tester.pumpWidget(buildTestableFieldWidget(testWidget));
+
+        // Set custom error
+        textFieldKey.currentState?.invalidate(errorTextField);
+        await tester.pumpAndSettle();
+
+        expect(textFieldKey.currentState?.valueIsValid, isTrue);
+      });
+    });
+
+    group('valueHasError -', () {
+      testWidgets('Should value is invalid when validator passes',
+          (tester) async {
+        final textFieldKey = GlobalKey<FormBuilderFieldState>();
+        const textFieldName = 'text';
+        const invalidValue = 'invalid';
+        final testWidget = FormBuilderTextField(
+          name: textFieldName,
+          key: textFieldKey,
+          initialValue: invalidValue,
+          validator: (value) => (value == invalidValue) ? 'error' : null,
+          autovalidateMode: AutovalidateMode.always,
+        );
+        await tester.pumpWidget(buildTestableFieldWidget(testWidget));
+
+        expect(textFieldKey.currentState?.valueHasError, isTrue);
+      });
+    });
+
     group('autovalidateMode -', () {
       testWidgets(
           'Should show error when init form and AutovalidateMode is always',