start documenting confirmation_status.rs #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zancas
commented
Nov 15, 2023
| @@ -16,9 +22,9 @@ fn u32_height_or_placeholder(option_blockheight: Option<BlockHeight>) -> u32 { | |||
| #[derive(Clone, Copy, Debug, PartialEq)] | |||
| pub enum ConfirmationStatus { | |||
| Local, | |||
There was a problem hiding this comment.
I tried to think of other idents than "Local".. but I think in the end I decided I liked "Local" more than the alternatives I came up with.
zancas
commented
Nov 15, 2023
| @@ -29,13 +36,13 @@ impl ConfirmationStatus { | |||
| pub fn is_confirmed(&self) -> bool { | |||
| matches!(self, Self::ConfirmedOnChain(_)) | |||
| } | |||
| pub fn is_confirmed_after_or_at(&self, height: &BlockHeight) -> bool { | |||
| pub fn is_confirmed_at_or_above(&self, height: &BlockHeight) -> bool { | |||
There was a problem hiding this comment.
What's the rationale for having these predicates structured in this way? I kind of like the idea that if one's true that the other's false?
I renamed these using the height metaphor since that's consistent with the "BlockHeight" nym.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.