Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: column reordering #1539

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

pedrolamas
Copy link
Member

@pedrolamas pedrolamas commented Nov 23, 2024

Adds column drag & drop to reorder on the column picker.

This applies to:

  • File Browser
  • Job Queue
  • Job History
  • Spoolman selection dialog

image

Resolves #1538

@pedrolamas pedrolamas added FR - Enhancement New feature or request UI - QoL Improvements to the UI UI - Change All matters related to a significant change in the UI labels Nov 23, 2024
@pedrolamas pedrolamas added this to the 1.31 milestone Nov 23, 2024
@pedrolamas pedrolamas mentioned this pull request Nov 23, 2024
@pedrolamas pedrolamas marked this pull request as ready for review November 23, 2024 22:30
@pedrolamas
Copy link
Member Author

@matmen regarding Spoolman, are those all the columns we can have on that dialog or are there more we can provide so users can pick & choose?

Signed-off-by: Pedro Lamas <[email protected]>
@matmen
Copy link
Member

matmen commented Nov 24, 2024

There's a bunch more fields that are supported OOTB (like density, diameter, extruder/bed temp), but I'm not sure it makes sense to display them in the spool selection modal, though it would probably make sense to support them and hide them by default? I'm planning to add the same functionality for the dashboard card in the future, as well as support for showing custom fields defined in Spoolman itself.
Not sure why, but when I open the spool selection modal with this patch applied none of the headers except for "Filament" have a name? All the other components seem fine.
image

@pedrolamas
Copy link
Member Author

Not sure why, but when I open the spool selection modal with this patch applied none of the headers except for "Filament" have a name? All the other components seem fine.

That's very odd, should work just fine... are you using German as base language?

@pedrolamas pedrolamas merged commit 852c0ee into fluidd-core:develop Nov 24, 2024
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/column-order branch November 24, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request UI - Change All matters related to a significant change in the UI UI - QoL Improvements to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column Order
2 participants