-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update assigncache_test.go #3338
Conversation
Hi @cqy191220018. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Kudos, SonarCloud Quality Gate passed! |
@cqy191220018 please fix DCO issue by following the link: https://github.com/fluid-cloudnative/fluid/pull/3338/checks?check_run_id=14974243073 |
Signed-off-by: cheyang <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #3338 +/- ##
==========================================
- Coverage 65.58% 64.29% -1.29%
==========================================
Files 396 442 +46
Lines 22798 26452 +3654
==========================================
+ Hits 14951 17007 +2056
- Misses 6098 7440 +1342
- Partials 1749 2005 +256
|
Signed-off-by: cheyang <[email protected]>
Ⅰ. Describe what this PR does
任务内容:文件头部添加或规范化License内容
修改位置:pkg/utils/dataset/lifecycle/assigncache_test.go
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews