Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assigncache_test.go #3338

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Update assigncache_test.go #3338

merged 1 commit into from
Sep 20, 2023

Conversation

cqy191220018
Copy link
Contributor

Ⅰ. Describe what this PR does

任务内容:文件头部添加或规范化License内容

修改位置:pkg/utils/dataset/lifecycle/assigncache_test.go

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jul 12, 2023

Hi @cqy191220018. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cheyang
Copy link
Collaborator

cheyang commented Jul 14, 2023

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #3338 (61ca88f) into master (bb80e59) will decrease coverage by 1.29%.
Report is 366 commits behind head on master.
The diff coverage is 83.87%.

❗ Current head 61ca88f differs from pull request most recent head 0a6dc29. Consider uploading reports for the commit 0a6dc29 to get more accurate results

@@            Coverage Diff             @@
##           master    #3338      +/-   ##
==========================================
- Coverage   65.58%   64.29%   -1.29%     
==========================================
  Files         396      442      +46     
  Lines       22798    26452    +3654     
==========================================
+ Hits        14951    17007    +2056     
- Misses       6098     7440    +1342     
- Partials     1749     2005     +256     
Files Changed Coverage Δ
api/v1alpha1/alluxioruntime_types.go 33.33% <ø> (ø)
api/v1alpha1/common.go 0.00% <ø> (ø)
api/v1alpha1/databackup_types.go 100.00% <ø> (ø)
api/v1alpha1/dataload_types.go 100.00% <ø> (ø)
api/v1alpha1/datamigrate_types.go 100.00% <ø> (ø)
api/v1alpha1/goosefsruntime_types.go 33.33% <ø> (ø)
api/v1alpha1/jindoruntime_types.go 33.33% <ø> (ø)
api/v1alpha1/juicefsruntime_types.go 33.33% <ø> (ø)
api/v1alpha1/thinruntime_types.go 33.33% <ø> (ø)
api/v1alpha1/efcruntime_types.go 11.11% <16.66%> (ø)
... and 2 more

... and 247 files with indirect coverage changes

@cheyang cheyang merged commit 208b672 into fluid-cloudnative:master Sep 20, 2023
cheyang pushed a commit to cheyang/fluid that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants