support juicefs cloud service #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: zwwhdls <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 70.76% 70.89% +0.12%
==========================================
Files 238 238
Lines 13129 13201 +72
==========================================
+ Hits 9291 9359 +68
- Misses 2843 2845 +2
- Partials 995 997 +2
Continue to review full report at Codecov.
|
|
@zwwhdls Please fix conflict issue. Thanks. |
cheyang
requested changes
Mar 30, 2022
charts/juicefs/values.yaml
Outdated
| @@ -1,5 +1,6 @@ | |||
| # This should not be modified in the usual case. | |||
| fullnameOverride: juicefs | |||
| isCe: false | |||
There was a problem hiding this comment.
I suggest using meaningful name, because I'm worried about forgetting the meaning of the name in future.
Signed-off-by: zwwhdls <[email protected]>
…ort_juciefs_enterprise
Signed-off-by: zwwhdls <[email protected]>
cheyang
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zwwhdls [email protected]
Ⅰ. Describe what this PR does
support juicefs cloud service in JuiceFSRuntime
fix #1682
Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews