[BugFix #1551] change mountTime to *v1.Time #1610
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1610 +/- ##
==========================================
+ Coverage 70.76% 70.89% +0.12%
==========================================
Files 238 238
Lines 13129 13201 +72
==========================================
+ Hits 9291 9359 +68
- Misses 2843 2845 +2
- Partials 995 997 +2
Continue to review full report at Codecov.
|
|
Sorry for the latency, changed as suggested. |
|
Thanks @zwwhdls for review |
|
@Nizifan Please fix the DCO issue by following https://github.com/fluid-cloudnative/fluid/pull/1610/checks?check_run_id=5767953892 |
Signed-off-by: nizifan <[email protected]>
Signed-off-by: nizifan <[email protected]>
Signed-off-by: nizifan <[email protected]>
| @@ -1,13 +1,32 @@ | |||
|
|
|||
| --- | |||
| apiVersion: apiextensions.k8s.io/v1 | |||
| apiVersion: apiextensions.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
Why changing CRD version back from v1 to v1beta1. I think this version CRD is deprecated in K8s 1.22.
There was a problem hiding this comment.
This is auto generated.
| kind: CustomResourceDefinition | ||
| metadata: | ||
| annotations: | ||
| controller-gen.kubebuilder.io/version: v0.7.0 | ||
| controller-gen.kubebuilder.io/version: v0.3.0 |
There was a problem hiding this comment.
I think you should build with controller generator with 0.7.0+ .
There was a problem hiding this comment.
I follow the instruction to use 0.3.0 ...
I change it back to 0.7.0 now.
|
I think it should be check nil : https://github.com/fluid-cloudnative/fluid/blob/master/pkg/ddc/alluxio/ufs.go#L156 |
Signed-off-by: nizifan <[email protected]>
|
@Nizifan Thanks for your fix. Look forward to your next PR. |
Signed-off-by: nizifan [email protected]
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews