Optimize CSI Plugin node server logic #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TrafalgarZZZ <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1582 +/- ##
=======================================
Coverage 70.76% 70.76%
=======================================
Files 238 238
Lines 13129 13129
=======================================
Hits 9291 9291
Misses 2843 2843
Partials 995 995
Continue to review full report at Codecov.
|
cheyang
reviewed
Mar 23, 2022
cheyang
reviewed
Mar 23, 2022
cheyang
reviewed
Mar 23, 2022
| return volume.GetNamespacedNameByVolumeId(ns.apiReader, volumeId) | ||
| } | ||
|
|
||
| // getNode first checks cached node | ||
| func (ns *nodeServer) getNode() (node *v1.Node, err error) { |
There was a problem hiding this comment.
Need add UT for this function.
zwwhdls
approved these changes
Mar 23, 2022
Signed-off-by: TrafalgarZZZ <[email protected]>
cheyang
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TrafalgarZZZ [email protected]
Ⅰ. Describe what this PR does
Optimize CSI Plugin node server logic.
This PR caches node to avoid frequent requests to api server
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews