Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename MAINTAINERS.md to MAINTAINERS_COMMITTER.md #1514

Closed
wants to merge 2 commits into from

Conversation

RongGu
Copy link
Member

@RongGu RongGu commented Mar 11, 2022

add committer list.

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #1514 (bbd62c7) into master (4d729ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1514   +/-   ##
=======================================
  Coverage   70.69%   70.69%           
=======================================
  Files         235      235           
  Lines       12909    12909           
=======================================
  Hits         9126     9126           
  Misses       2805     2805           
  Partials      978      978           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d729ac...bbd62c7. Read the comment docs.

@cheyang
Copy link
Collaborator

cheyang commented Mar 12, 2022

@RongGu Could you please fix the DCO issue by following the guide:

https://github.com/fluid-cloudnative/fluid/pull/1514/checks?check_run_id=5511329692

1. Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
2. In your local branch, run: git rebase HEAD~2 --signoff
3. Force push your changes to overwrite the branch: git push --force-with-lease origin RongGu-patch-8

Thanks.

@RongGu RongGu closed this Mar 13, 2022
@RongGu
Copy link
Member Author

RongGu commented Mar 13, 2022

@RongGu Could you please fix the DCO issue by following the guide:

https://github.com/fluid-cloudnative/fluid/pull/1514/checks?check_run_id=5511329692

1. Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
2. In your local branch, run: git rebase HEAD~2 --signoff
3. Force push your changes to overwrite the branch: git push --force-with-lease origin RongGu-patch-8

Thanks.

Thank you. This PR is resbumitted here #1517.

@cheyang cheyang deleted the RongGu-patch-8 branch March 22, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants