Build docker image for fixing dataload issue #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cheyang <[email protected]>
zwwhdls
pushed a commit
to ldd91/fluid
that referenced
this pull request
Mar 18, 2022
Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]>
cheyang
added a commit
that referenced
this pull request
Mar 22, 2022
* Add helm lint check in Github workflow (#1384) * Add helm lint check in Github workflow Signed-off-by: TrafalgarZZZ <[email protected]> * Fix jindofs helm lint Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * add juicefsruntime dataload Signed-off-by: zwwhdls <[email protected]> * fix test Signed-off-by: zwwhdls <[email protected]> * Add documents for debuging (#1387) * Add pd documents, To #38946668 Signed-off-by: cheyang <[email protected]> * Add pd documents, To #38946668 Signed-off-by: cheyang <[email protected]> * Add pd documents, To #38946668 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * not check mount ready in stageVolume (#1390) Signed-off-by: zwwhdls <[email protected]> * Build docker image for csi plugin, To #38946668 (#1391) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Add remount check for hostpath mount during sync (#1340) * Add remount check for hostpath mount during sync Signed-off-by: nizifan <[email protected]> * Fix CI issue & rename function Signed-off-by: nizifan <[email protected]> * Add ut & fix potential leak of ufstoupdate.toadd Signed-off-by: nizifan <[email protected]> * improve test coverage & address comments - add new line Signed-off-by: nizifan <[email protected]> * Fix ci issue Signed-off-by: nizifan <[email protected]> * Only perform remount operation when mounttime ealier than master starting time Signed-off-by: nizifan <[email protected]> * Fix ci issue Signed-off-by: nizifan <[email protected]> * add ut Signed-off-by: nizifan <[email protected]> * rename function Signed-off-by: nizifan <[email protected]> Co-authored-by: nizifan <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Jindo fuse recover support and upgrade jindofs version (#1385) * JindoFS fuse recover Signed-off-by: frankleaf <[email protected]> * refine Signed-off-by: frankleaf <[email protected]> * refine Signed-off-by: frankleaf <[email protected]> * refine Signed-off-by: frankleaf <[email protected]> * refine Signed-off-by: frankleaf <[email protected]> * refine Signed-off-by: frankleaf <[email protected]> Signed-off-by: zwwhdls <[email protected]> * unify the file format under cmd, alluxio jindo dataset (#1388) Signed-off-by: mahao <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Docker image build for alluxio master restart (#1393) * Fix format, To #38946668 Signed-off-by: cheyang <[email protected]> * Add volume, To #38946668 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Refactor Fluid CSI Plugin (#1395) * Refactor Fluid CSI Plugin Signed-off-by: TrafalgarZZZ <[email protected]> * Go fmt Signed-off-by: TrafalgarZZZ <[email protected]> * Option to enable fuse mount point recovery Signed-off-by: TrafalgarZZZ <[email protected]> * Refactor Fluid CSI Plugin - Move package 'mountinfo' to utils - Move package 'fuse' to plugin - Add registry functions Signed-off-by: TrafalgarZZZ <[email protected]> * Minor fix for fuse recover period Signed-off-by: TrafalgarZZZ <[email protected]> * Remove duplicate license Signed-off-by: TrafalgarZZZ <[email protected]> * Declare registraion funcs to enable/disable feature gates Signed-off-by: TrafalgarZZZ <[email protected]> * Add tests Signed-off-by: TrafalgarZZZ <[email protected]> * Add tests Signed-off-by: TrafalgarZZZ <[email protected]> * Fix copyright Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build docker images for refactoring csi plugin, To #38946668 (#1397) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * fix diagnose (#1402) Signed-off-by: ssz1997 <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Support fuse sidecar injection (#1401) * Support serverless, To #38946668 Signed-off-by: cheyang <[email protected]> Fix ut, To #38946668 Signed-off-by: cheyang <[email protected]> * Signed-off-by: cheyang <[email protected]> Add mountPropagationHostToContainer, To #37688693 Add testcase, To #37688693 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Fix building docker image for init user (#1408) * Fix docker build for cento8, To #37688693 Signed-off-by: cheyang <[email protected]> * Fix docker build for cento8, To #37688693 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build docker image (#1409) * Build docker image, To #37688693 Signed-off-by: cheyang <[email protected]> * Build docker image, To #37688693 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Make AlluxioRuntime support serverless (#1411) * Support Alluxio, To #37688693 Signed-off-by: cheyang <[email protected]> * Support Alluxio, To #37688693 Signed-off-by: cheyang <[email protected]> * Support Alluxio, To #37688693 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Support pod's namespace is empty in webhook (#1413) * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> * Support namespace is empty, To #37688693 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Support namespace is empty, To #37688693 (#1415) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Fix redundant type from array, slice, or map composite literal (#1417) * Fix redundant type from array, slice, or map composite literal, To #37688693 Signed-off-by: cheyang <[email protected]> * Fix redundant type from array, slice, or map composite literal, To #37688693 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Fix dataload cannot be cleaned up bug (#1421) Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Add testcase, To #37688693 (#1423) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * fix goosefs error (#1422) * change goosefs fuse default parameters; fix redundant type from array, slice, or map composite literal; fix when ha mode journal type Signed-off-by: xieydd <[email protected]> * fix comments Signed-off-by: xieydd <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build docker image for goose, To #37688693 (#1425) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * support juicefs in serverless (#1427) Signed-off-by: zwwhdls <[email protected]> * Build docker image for juicefs on serverless, To #37688693 (#1432) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * (GooseFS) [Bug Fix] Fix clean cache linux version error (#1428) * fix clean cache linux version error Signed-off-by: xieydd <[email protected]> * update goosefs default image to 1.2.0 Signed-off-by: xieydd <[email protected]> * fix comment Signed-off-by: xieydd <[email protected]> * fix timeout option for ubuntu and alpine base image Signed-off-by: xieydd <[email protected]> * fix timeout option for ubuntu and alpine base image Signed-off-by: xieydd <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build docker image for Goosefs bug, To #37688693 (#1434) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Fix update dataload status error (#1433) * Fix update dataload status error Signed-off-by: Ruofeng Lei <[email protected]> * Fix some incorrect usage of `ctx.Name` Signed-off-by: Ruofeng Lei <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Fix update dataload status error, To #37688693 (#1437) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * disable fuse.shared.caching.reader.enabled for alluxio and goosefs, see Alluxio/alluxio#14909 (#1400) Signed-off-by: nizifan <[email protected]> Co-authored-by: nizifan <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Update ADOPTERS.md (#1440) Pxing AI training platform is testing fluid. Signed-off-by: zwwhdls <[email protected]> * Remove the removed watermark configure key (#1439) Signed-off-by: maobaolong <[email protected]> Signed-off-by: zwwhdls <[email protected]> * add feature gate to csi (#1444) * add feature gate to csi Signed-off-by: zwwhdls <[email protected]> * update period to time.Duration & delete period in config Signed-off-by: zwwhdls <[email protected]> * Make controllers handle deprecated runtime workers (#1447) * Handle deprecated worker daemonset Signed-off-by: TrafalgarZZZ <[email protected]> * Record events to runtime when detecting deprecated runtimes Signed-off-by: TrafalgarZZZ <[email protected]> * More detailed event message Signed-off-by: TrafalgarZZZ <[email protected]> * Add ut for Alluxio and GooseFs Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Docs for serverless (#1443) * Add doc, To #37688693 Signed-off-by: cheyang <[email protected]> * Build docker image, To #39482462 Signed-off-by: cheyang <[email protected]> * Build docker image, To #39482462 Signed-off-by: cheyang <[email protected]> * Build docker image, To #39482462 Signed-off-by: cheyang <[email protected]> * Fluid for serverless, To #37688693 Signed-off-by: cheyang <[email protected]> * Fluid for serverless, To #37688693 Signed-off-by: cheyang <[email protected]> * Fluid for serverless, To #37688693 Signed-off-by: cheyang <[email protected]> * Fluid for serverless, To #37688693 Signed-off-by: cheyang <[email protected]> * Fluid for serverless, To #37688693 Signed-off-by: cheyang <[email protected]> * Fix update dataload status error, To #37688693 Signed-off-by: cheyang <[email protected]> * Build docker image, To #39482462 Signed-off-by: cheyang <[email protected]> * Build docker image, To #39482462 Signed-off-by: cheyang <[email protected]> * Build docker image, To #39482462 Signed-off-by: cheyang <[email protected]> * Fluid for serverless, To #37688693 Signed-off-by: cheyang <[email protected]> * Fluid for serverless, To #37688693 Signed-off-by: cheyang <[email protected]> * Fluid for serverless, To #37688693 Signed-off-by: cheyang <[email protected]> * Fluid for serverless, To #37688693 Signed-off-by: cheyang <[email protected]> * Add volume, To #38946668 Signed-off-by: cheyang <[email protected]> * Add volume, To #38946668 Signed-off-by: cheyang <[email protected]> * Add doc, To #38946668 Signed-off-by: cheyang <[email protected]> * Add doc, To #38946668 Signed-off-by: cheyang <[email protected]> * Fluid for serverless, To #37688693 Signed-off-by: cheyang <[email protected]> * Add doc, To #38946668 Signed-off-by: cheyang <[email protected]> * Fix ut, To #38946668 Signed-off-by: cheyang <[email protected]> * Fix ut, To #38946668 Signed-off-by: cheyang <[email protected]> * Update docs, To #39482462 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build docker image, To #39482462 (#1449) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Use less job worker threads (#1450) Signed-off-by: ssz1997 <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build for GROMACS, To #26045127 (#1452) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Fix csi daemonset template typo (#1454) Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Update Fluid documents (#1455) * Update Fluid docs Signed-off-by: TrafalgarZZZ <[email protected]> * Update Fluid docs Signed-off-by: TrafalgarZZZ <[email protected]> * Update Fluid docs Signed-off-by: TrafalgarZZZ <[email protected]> * Update Fluid docs Signed-off-by: TrafalgarZZZ <[email protected]> * Update Fluid docs Signed-off-by: TrafalgarZZZ <[email protected]> * Update Fluid docs Signed-off-by: TrafalgarZZZ <[email protected]> * Update Fluid docs Signed-off-by: TrafalgarZZZ <[email protected]> * Update Fluid docs Signed-off-by: TrafalgarZZZ <[email protected]> * Update Fluid docs(en) Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * fix gen_sdk.sh (#1457) * fix gen_sdk.sh Signed-off-by: zwwhdls <[email protected]> * fix swagger url & delete useless env Signed-off-by: zwwhdls <[email protected]> * keep swagger-codegen-cli.jar in project Signed-off-by: zwwhdls <[email protected]> * Archive deprecated Fluid documents (#1458) * Archive deprecated documents Signed-off-by: TrafalgarZZZ <[email protected]> * Update data colocality document Signed-off-by: TrafalgarZZZ <[email protected]> * Update pod schedule document Signed-off-by: TrafalgarZZZ <[email protected]> * Refactor table of contents Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Remove cache dir from sidecar pod (#1462) * Remove cache dir, To #39482462 Signed-off-by: cheyang <[email protected]> * Remove cache dir, To #39482462 Signed-off-by: cheyang <[email protected]> * Remove cache dir, To #39482462 Signed-off-by: cheyang <[email protected]> * Add Fuse container sidecar test, To #37688693 Signed-off-by: cheyang <[email protected]> * Add Fuse container sidecar test, To #37688693 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Add Docker image for fuse without cachedir, To #37688693 (#1464) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Disable timezone hostpath for jindoruntime, To #37688693 (#1466) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build docker image for disabling timezone hostpath for jindoruntime, To #37688693 (#1468) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * remove duplicates in Makefile (#1472) Signed-off-by: wangxu <[email protected]> Co-authored-by: wangxu <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Add community meeting information (#1471) Add community meeting information Signed-off-by: zwwhdls <[email protected]> * Update docs for enabling cache dir (#1474) * Add samples, To #26045127 Signed-off-by: cheyang <[email protected]> * Docs for knative, To #37688693 Signed-off-by: cheyang <[email protected]> * Docs for knative, To #37688693 Signed-off-by: cheyang <[email protected]> * Add samples, To #26045127 Signed-off-by: cheyang <[email protected]> * Add samples, To #26045127 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Update install document (#1475) * Update install document (zhCN) Signed-off-by: TrafalgarZZZ <[email protected]> * Update install document (en) Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * enable run jindo dataload synchronously (#1477) Signed-off-by: frankleaf <[email protected]> Signed-off-by: zwwhdls <[email protected]> * fix jindo some parameter to bool (#1480) * enable run jindo dataload synchronously Signed-off-by: frankleaf <[email protected]> * fix digit to ture/false Signed-off-by: frankleaf <[email protected]> * fix test Signed-off-by: frankleaf <[email protected]> * fix test Signed-off-by: frankleaf <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build docker image for release v0.7.0, To #39482692 (#1484) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Fix typo in install document (#1486) Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * modify bug : clean cache in Alluxio due to unknown linux release version (#1487) * remove duplicates in Makefile Signed-off-by: wangxu <[email protected]> * deal with issue 1476 Signed-off-by: wangxu <[email protected]> Co-authored-by: wangxu <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build docker image for 0.7.0 release, To #37688693 (#1488) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Added what's new for v0.7 release (#1489) Added what's new for v0.7 release Signed-off-by: zwwhdls <[email protected]> * Branch v0.8.0 (#1491) * Update for v0.8.0, To #39858484 Signed-off-by: cheyang <[email protected]> * Update for v0.8.0, To #39858484 Signed-off-by: cheyang <[email protected]> * Update for v0.8.0, To #39858484 Signed-off-by: cheyang <[email protected]> * Update for v0.8.0, To #39858484 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Update CHANGELOG.md for 0.7 (#1493) Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * modify userguide faq zh & en documents (#1502) Signed-off-by: Javy <[email protected]> Co-authored-by: Javy <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Default csi fuse recovery to false (#1501) Signed-off-by: TrafalgarZZZ <[email protected]> Signed-off-by: zwwhdls <[email protected]> * add s3 example (#1494) * add s3 example Signed-off-by: ssz1997 <[email protected]> * Update s3 doc Signed-off-by: ssz1997 <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Fix misleading logging in csi plugin (#1499) * Fix logging for init opts, To #39858484 Signed-off-by: cheyang <[email protected]> * Fix logging for init opts, To #39858484 Signed-off-by: cheyang <[email protected]> * Fix logging for init opts, To #39858484 Signed-off-by: cheyang <[email protected]> * Fix logging for init opts, To #39858484 Signed-off-by: cheyang <[email protected]> * Fix logging for init opts, To #39858484 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * add dmetasoul.com in adopters documents (#1506) Signed-off-by: Javy <[email protected]> Co-authored-by: Javy <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Updated the Chinese version of the S3 configuration document and added the English version of the S3 configuration document (#1507) Signed-off-by: Javy <[email protected]> Co-authored-by: Javy <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build docker image for env in csi plugin, To #37688693 (#1509) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * Build docker image for env in csi plugin, To #37688693 (#1510) Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * fix update JindoRuntime doc link (#1512) Signed-off-by: frankleaf <[email protected]> Signed-off-by: zwwhdls <[email protected]> * update data_warm_up's document (#1513) * Updated the Chinese version of the S3 configuration document and added the English version of the S3 configuration document Signed-off-by: Javy <[email protected]> * update data_warm_up's document Signed-off-by: Javy <[email protected]> Co-authored-by: Javy <[email protected]> Signed-off-by: zwwhdls <[email protected]> * add fluid app controller (#1481) * add fluid app controller Signed-off-by: zwwhdls <[email protected]> * fix ci-lint Signed-off-by: zwwhdls <[email protected]> * add watch func in fluid app controller Signed-off-by: zwwhdls <[email protected]> * fix chart lint Signed-off-by: zwwhdls <[email protected]> * reduce rbac Signed-off-by: zwwhdls <[email protected]> * use util instead Signed-off-by: zwwhdls <[email protected]> * update rbac Signed-off-by: zwwhdls <[email protected]> * update rbac Signed-off-by: zwwhdls <[email protected]> * Update committer name list. (#1517) * update committer and maintainer file Signed-off-by: RongGu <[email protected]> * update Governance file to add committer list file Signed-off-by: RongGu <[email protected]> * fix typo Signed-off-by: RongGu <[email protected]> Signed-off-by: zwwhdls <[email protected]> * fix pod/exec rbac in application controller (#1518) Signed-off-by: zwwhdls <[email protected]> * Build docker image for fluid app controller (#1516) * Add samples, To #40056722 Signed-off-by: cheyang <[email protected]> * Add samples, To #40056722 Signed-off-by: cheyang <[email protected]> * Update dockerfile, To #40056722 Signed-off-by: cheyang <[email protected]> * Update dockerfile, To #40056722 Signed-off-by: cheyang <[email protected]> * Build docker image for env in csi plugin, To #37688693 Signed-off-by: cheyang <[email protected]> Signed-off-by: zwwhdls <[email protected]> * fix application controller image (#1519) Signed-off-by: zwwhdls <[email protected]> * warmup in each fuse pod Signed-off-by: zwwhdls <[email protected]> * fix test Signed-off-by: zwwhdls <[email protected]> * update default fuse image Signed-off-by: zwwhdls <[email protected]> * add label in job Signed-off-by: zwwhdls <[email protected]> * fix DCO Signed-off-by: zwwhdls <[email protected]> * update typo Signed-off-by: zwwhdls <[email protected]> * update dataload rbac to juicefs controller Signed-off-by: zwwhdls <[email protected]> * update warmup to worker Signed-off-by: zwwhdls <[email protected]> * add timeout & deal with error Signed-off-by: zwwhdls <[email protected]> * set timeout in dataload options Signed-off-by: zwwhdls <[email protected]> * update configmap volume mode 0755 & add unit test Signed-off-by: zwwhdls <[email protected]> Co-authored-by: TzZtzt <[email protected]> Co-authored-by: zwwhdls <[email protected]> Co-authored-by: cheyang <[email protected]> Co-authored-by: Nizifan <[email protected]> Co-authored-by: nizifan <[email protected]> Co-authored-by: frankleaf <[email protected]> Co-authored-by: Allen <[email protected]> Co-authored-by: Shawn Sun <[email protected]> Co-authored-by: xieydd <[email protected]> Co-authored-by: Ruofeng Lei <[email protected]> Co-authored-by: peterchenhc <[email protected]> Co-authored-by: maobaolong <[email protected]> Co-authored-by: haoeeeee <[email protected]> Co-authored-by: wangxu <[email protected]> Co-authored-by: Rong Gu <[email protected]> Co-authored-by: Javy <[email protected]> Co-authored-by: Javy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cheyang [email protected]
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #1424
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews