support alluxio container network #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenhaozi
force-pushed
the
feat/alluxio-container-network
branch
2 times, most recently
from
8ee8252 to
4eb289e
Compare
Signed-off-by: mahao <[email protected]>
allenhaozi
force-pushed
the
feat/alluxio-container-network
branch
from
4eb289e to
9729a91
Compare
Codecov Report
@@ Coverage Diff @@
## master #1287 +/- ##
===========================================
- Coverage 69.15% 53.27% -15.88%
===========================================
Files 269 279 +10
Lines 15475 20124 +4649
===========================================
+ Hits 10702 10722 +20
- Misses 3622 8251 +4629
Partials 1151 1151
Continue to review full report at Codecov.
|
allenhaozi
force-pushed
the
feat/alluxio-container-network
branch
4 times, most recently
from
cae256c to
9630a4c
Compare
Signed-off-by: mahao <[email protected]>
allenhaozi
force-pushed
the
feat/alluxio-container-network
branch
from
9630a4c to
a210356
Compare
|
@cheyang Please review this pr. thank you |
zwwhdls
reviewed
May 20, 2022
cheyang
reviewed
May 20, 2022
cheyang
reviewed
May 20, 2022
charts/alluxio/values.yaml
Outdated
| @@ -12,7 +12,6 @@ | |||
| # This should not be modified in the usual case. | |||
| fullnameOverride: alluxio | |||
|
|
|||
There was a problem hiding this comment.
Could you update the version and changelog in alluxio chart? thanks.
cheyang
reviewed
May 20, 2022
| @@ -12,6 +12,7 @@ | |||
| {{ if .Values.fuse.enabled -}} | |||
| {{- $shortCircuitEnabled := .Values.shortCircuit.enabled -}} | |||
| {{- $needDomainSocketVolume := and $shortCircuitEnabled (eq .Values.shortCircuit.policy "uuid") }} | |||
| {{- $fuseHostNetwork := .Values.fuse.hostNetwork }} | |||
|
|
|||
| apiVersion: apps/v1 | |||
There was a problem hiding this comment.
Do we need the following configuration?
- name: ALLUXIO_WORKER_CONTAINER_HOSTNAME
valueFrom:
fieldRef:
fieldPath: status.podIP
allenhaozi
force-pushed
the
feat/alluxio-container-network
branch
from
07f867a to
5600d8b
Compare
allenhaozi
force-pushed
the
feat/alluxio-container-network
branch
from
5600d8b to
858e477
Compare
allenhaozi
force-pushed
the
feat/alluxio-container-network
branch
from
b32be6f to
32af4df
Compare
allenhaozi
force-pushed
the
feat/alluxio-container-network
branch
from
32af4df to
340484f
Compare
cheyang
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mahao [email protected]
Ⅰ. Describe what this PR does
support alluxio container network
Ⅱ. Does this pull request fix one issue?
#989
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews