[#360] Add include support for Ruby DSL #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if args.first =~ /\.rb$/ | ||
| path = File.expand_path(args.first) | ||
| data = File.read(path) | ||
| self.instance_eval(data, @proxy.include_basepath) |
There was a problem hiding this comment.
The 2nd argument of instance_eval should be the filename (path), not base path.
|
Almost looks good to me. |
mod instance_eval 2nd args
|
@tagomoris and ... dsl code is cool!! why test is failed?? |
|
Merged. Thank you for contribution! |
|
This patch disables (overwrites) |
repeatedly
pushed a commit
that referenced
this pull request
Jun 16, 2016
[#360] Add include support for Ruby DSL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add include support for Ruby DSL.
And Fix bug parser include at the Windows.
Like this conditions
Because
URI.parsereturnu.scheme = c.When Windows absolute path is
C:/projects/fluentd/test/tmp/config.Then used
open-uriand basepath change/.But after merge this PR.
There is a bug.
When It has some drives In the Windows.
Like a C: and D:
And upper case.
I think it is rare case.
If you need fix this bug.
Please make issue.