Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for drop_oldest_chunk when buffer queue is full #934

Merged
merged 1 commit into from
May 11, 2016

Conversation

varunkumta
Copy link

  • Drop oldest chunk from queue without writing to output when buffer
    queue is full
  • Add test

- Drop oldest chunk from queue without writing to output when buffer
queue is full
- Add test
@repeatedly repeatedly self-assigned this May 6, 2016
@repeatedly
Copy link
Member

I will check it later.
Supporting drop_oldest_chunk itself is no problem for me.

@repeatedly
Copy link
Member

@varunkumta Could you write your use case?

@agup006
Copy link
Member

agup006 commented May 9, 2016

Hi @repeatedly, Use case is for when output plugin relies on time sensitive data and cannot be reached. E.g. connection on FluentD node is blocked or if service is down - continue to rotate data and switch newest data in for oldest data.

@varunkumta
Copy link
Author

@repeatedly , @agup006 and I work on the Linux omsagent (https://github.com/Microsoft/Build-OMS-Agent-for-Linux) - and the use case he mentioned is one we are adding for handling network outages better, since the data we collect like perf counters is more useful the more recent it is. So we drop older data in favor of newer data.

@repeatedly
Copy link
Member

@varunkumta @agup006 I understood the situation and I don't have a counter opinion.

@sonots @tagomoris If there is no concern, I will merge this patch.

@tagomoris
Copy link
Member

LGTM.

@repeatedly repeatedly merged commit 7031bfa into fluent:v0.12 May 11, 2016
@repeatedly repeatedly added v0.12 feature request *Deprecated Label* Use enhancement label in general labels May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request *Deprecated Label* Use enhancement label in general v0.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants