Add "encoding" parameter to in_tail plugin #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -370,6 +381,42 @@ def test_whitespace | |||
| assert_equal({"message" => "tab "}, emits[5][2]) | |||
| end | |||
|
|
|||
| def test_default_encoding | |||
| File.open("#{TMP_DIR}/tail.txt", "wb") {|f| } | |||
There was a problem hiding this comment.
Setting read_from_head true is better than creating a file here?
|
@repeatedly I have refined the tests. It seems that the failure on Travis CI (https://travis-ci.org/fluent/fluentd/jobs/122757775) is not related with this PR. Could you restart the job? |
|
It seems ok for me. @tagomoris @sonots How about this? |
| begin | ||
| Encoding.find(encoding_name) | ||
| rescue ArgumentError => e | ||
| raise ConfigError.new(e.message) |
There was a problem hiding this comment.
Newing error looks a bit curious for me. I like: raise ConfigError, e.message
|
LGTM!! |
|
Totally LGTM. |
|
Thanks! |
repeatedly
added
v0.12
feature request
repeatedly
added a commit
that referenced
this pull request
May 16, 2016
Add "encoding" parameter to in_tail plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
in_tailplugin emits strings with ASCII-8BIT encoding, which is resulted from IO#readpartial. This behavior entails inconvenience when filtering records. For example:This PR adds
encodingparameter to in_tail plugin, leaving ASCII-8BIT as default for compatibility.